Differential D2524

Drop Visual Studio 2013 support
ClosedPublic
Actions

Authored by Itms on Dec 30 2019, 6:19 PM.

Details

Reviewers

Silier

Commits

rP23382: Officially drop support for Visual Studio 2013, which stopped working after…

Summary

This (officially) drops VS2013 support and updates some code and some comments accordingly.

Note: The commit will also delete the following files, which arcanist is too stupid to mark as deleted without wanting to upload their current version (??)

D       binaries/system/mozjs45-ps-debug-vc120.dll
D       binaries/system/mozjs45-ps-debug-vc120.pdb
D       binaries/system/mozjs45-ps-release-vc120.dll
D       binaries/system/mozjs45-ps-release-vc120.pdb
D       libraries/source/spidermonkey/lib/mozjs45-ps-debug-vc120.lib
D       libraries/source/spidermonkey/lib/mozjs45-ps-release-vc120.lib

Test Plan

Test the simulation changes don't break anything. Nothing else should be impacted by this patch.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10576
Build 18148: Vulcan Build	Jenkins
Build 18147: Vulcan Build (macOS)	Jenkins
Build 18146: Vulcan Build (Windows)	Jenkins
Build 18145: arc lint + arc unit

Event Timeline

Itms created this revision.Dec 30 2019, 6:19 PM

Owners added a subscriber: Restricted Owners Package.Dec 30 2019, 6:19 PM

Itms mentioned this in D1411: Add commandline flag to set source and execution charsets to utf-8.Dec 30 2019, 6:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/914/display/redirect

Itms mentioned this in D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].Dec 30 2019, 6:35 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/8/display/redirect

Harbormaster failed remote builds in B10576: Diff 10828!Dec 30 2019, 6:54 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/system/ComponentManager.h
|  39| class·CComponentManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCComponentManager{' is invalid C code. Use --std or --language to configure the language.

source/lobby/glooxwrapper/glooxwrapper.h
|  88| namespace·glooxwrapper
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceglooxwrapper{' is invalid C code. Use --std or --language to configure the language.

source/scriptinterface/NativeWrapperDefns.h
|  25| template·<typename·T>·struct·ScriptInterface::MaybeRef
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1430/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/10/display/redirect

Harbormaster completed remote builds in B10576: Diff 10828.Dec 30 2019, 10:58 PM

Silier added inline comments.Dec 31 2019, 3:56 PM

source/scriptinterface/NativeWrapperDefns.h
52	this link is no more valid, so bug is still present for vs2015 ?

Itms added inline comments.Jan 7 2020, 12:11 PM

source/scriptinterface/NativeWrapperDefns.h
52	Yes the bug is still here. I don't know what to do with the link, as it's outdated, and Yves was not even sure it was that bug. I found some references to this kind of bug with an internet search, but I am not sure either that there is a specific place where it is stated that VS has this bug, and in which version of the compiler it is fixed.

Itms added a commit: rP23382: Officially drop support for Visual Studio 2013, which stopped working after….Jan 12 2020, 9:07 PM

@Angen I forgot to close the diff in rP23382 ?

If you want to accept it so I can close it, it would be great, sorry for the oversight...
By the way I kept the link as-is, because I don't want to loose information by changing the link to something else.

workspace and premake script updates are correct
workaround explicitly for vs2013 removal is ok
(planed to accept earlier but kind of forgot, sry)

This revision is now accepted and ready to land.Jan 13 2020, 8:03 AM

No problem, thank you!