Page MenuHomeWildfire Games

Make rallypoints moddable.
Needs ReviewPublic

Authored by Stan on Jan 6 2020, 6:20 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

TBD

Test Plan

TBD

Event Timeline

Stan created this revision.Jan 6 2020, 6:20 PM
Vulcan added a comment.Jan 6 2020, 6:23 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/964/display/redirect

Vulcan added a comment.Jan 6 2020, 6:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/60/display/redirect

Vulcan added a comment.Jan 6 2020, 6:29 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/CCmpVisualActor.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1482/display/redirect

Nescio added a subscriber: Nescio.Jan 7 2020, 4:01 PM
Nescio added inline comments.
binaries/data/mods/public/simulation/templates/special/rallypoint.xml
11

Why not {civ}_waypoint_flag?

Stan updated this revision to Diff 10911.Jan 7 2020, 5:38 PM

Working version!

Vulcan added a comment.Jan 7 2020, 5:39 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1489/display/redirect

Vulcan added a comment.Jan 7 2020, 6:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/971/display/redirect

Vulcan added a comment.Jan 7 2020, 6:29 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/67/display/redirect

Stan added inline comments.Jan 7 2020, 9:26 PM
binaries/data/mods/public/simulation/templates/special/rallypoint.xml
11

No reason. Do you think it's better?

Nescio added inline comments.Jan 9 2020, 2:40 PM
binaries/data/mods/public/simulation/templates/special/rallypoint.xml
11

Templates tend to start with the {civ}_ tag, e.g. athen_barracks.xml, as do unit icons, e.g. athen_champion_infantry.png, and actors are also grouped by their civilization.
I've no strong opinions on it, though, I was just asking out of curiosity. The organization of the art files is your domain.

Stan added inline comments.Jan 9 2020, 2:42 PM
binaries/data/mods/public/simulation/templates/special/rallypoint.xml
11

There is another flag called waypoint_flag_0ad so I wasn't sure. The naming conventions should prevail here.

Stan updated this revision to Diff 10943.Jan 9 2020, 2:51 PM

Fix useless prefix in CCmpVisualActor

Vulcan added a comment.Jan 9 2020, 2:54 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/990/display/redirect

Vulcan added a comment.Jan 9 2020, 2:56 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/86/display/redirect

Vulcan added a comment.Jan 9 2020, 2:57 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/CCmpVisualActor.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/CCmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1508/display/redirect

Stan updated this revision to Diff 10944.Jan 9 2020, 3:28 PM

Fix checkrefs.pl warnings.

Vulcan added a comment.Jan 9 2020, 3:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/991/display/redirect

Vulcan added a comment.Jan 9 2020, 3:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/87/display/redirect

Vulcan added a comment.Jan 9 2020, 3:33 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/CCmpVisualActor.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/CCmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1509/display/redirect

Stan updated this revision to Diff 10945.Jan 9 2020, 3:41 PM

Fix headers

Vulcan added a comment.Jan 9 2020, 3:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/992/display/redirect

Vulcan added a comment.Jan 9 2020, 3:45 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/88/display/redirect

Vulcan added a comment.Jan 9 2020, 3:45 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1510/display/redirect

Stan updated this revision to Diff 10961.Jan 10 2020, 4:59 PM

Use boost instead

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/999/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/95/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1517/display/redirect

Stan updated this revision to Diff 10962.Jan 10 2020, 5:05 PM

Use it for RallyPoint too

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1000/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/96/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1518/display/redirect

Nescio removed a subscriber: Nescio.Jan 10 2020, 6:20 PM
Stan updated this revision to Diff 10998.Jan 13 2020, 12:34 PM

Use the owner instead of the identity to pick the rally point template

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/120/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1024/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1542/display/redirect

Stan updated this revision to Diff 10999.Jan 13 2020, 12:45 PM

Fix copypasta

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/121/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1025/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1543/display/redirect