Differential D2541

Reorder rendering passes to decrease possible driver sync
ClosedPublic
Actions

Authored by vladislavbelov on Jan 7 2020, 1:29 AM.

Tags

None

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23370: Reorder rendering passes to decrease a possible driver synchronization

Summary

glGet* functions might cause synchronization. It's better to avoid them. during rendering. It's not a powerful optimization, It depends on many things. Locally I got only ~2% for the frame time.

The two main things: the change shouldn't decrease performance and it helps to have a more clear profiler results.

Test Plan

Apply the patch and compile the game
Make sure that the looks like before (with all options: PostProc on/off, FancyWater on/off,

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jan 7 2020, 1:29 AM

vladislavbelov added inline comments.

source/renderer/ShadowMap.cpp
602 ↗	(On Diff #10905)	This comment is related to the old code (rP3332). Where we have external dependency. Because we were rendering in unknown (for us - as ShadowMap) framebuffer.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/967/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/63/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/LOSTexture.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/PostprocManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/Renderer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1485/display/redirect

Harbormaster completed remote builds in B10657: Diff 10905.Jan 7 2020, 1:36 AM

vladislavbelov updated this revision to Diff 10967.Jan 11 2020, 1:04 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1004/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1522/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/100/display/redirect

Harbormaster completed remote builds in B10732: Diff 10967.Jan 11 2020, 1:11 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2020, 4:25 PM

Closed by commit rP23370: Reorder rendering passes to decrease a possible driver synchronization (authored by vladislavbelov). · Explain Why

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP23370: Reorder rendering passes to decrease a possible driver synchronization.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

graphics/

7 lines

renderer/

PostprocManager.cpp

8 lines

56 lines

7 lines

Diff 10976

ps/trunk/source/graphics/LOSTexture.cpp

Loading...

ps/trunk/source/renderer/PostprocManager.cpp

Loading...

ps/trunk/source/renderer/Renderer.cpp

Loading...

ps/trunk/source/renderer/ShadowMap.cpp

Loading...