Page MenuHomeWildfire Games
Differential D2544

[art/actors] fix space in actor file name
ClosedPublic
Actions

Authored by Nescio on Jan 7 2020, 7:08 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23344: Fix space in seleucid temple pediment. This is against the art naming…
Summary

This patch replaces a space ( ) with an underscore (_) in the file name of a structure prop, and fixed the only file that uses it (did a grep).

Test Plan

Should be unproblematic, but check nonetheless.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 7 2020, 7:08 PM
Owners added a subscriber: Restricted Owners Package.Jan 7 2020, 7:08 PM
Vulcan added a comment.Jan 7 2020, 7:08 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1491/display/redirect

Harbormaster failed remote builds in B10666: Diff 10913!Jan 7 2020, 7:08 PM
Vulcan added a comment.Jan 7 2020, 7:09 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/973/display/redirect

Nescio added a comment.Jan 7 2020, 7:10 PM

And Vulcan fails again because of exactly that space. What a surprise.

Vulcan added a comment.Jan 7 2020, 7:13 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/69/display/redirect

Nescio added a subscriber: Stan.Jan 7 2020, 8:06 PM
Stan accepted this revision.Jan 7 2020, 9:29 PM
This revision is now accepted and ready to land.Jan 7 2020, 9:29 PM
This revision was landed with ongoing or failed builds.Jan 7 2020, 9:45 PM
Closed by commit rP23344: Fix space in seleucid temple pediment. This is against the art naming… (authored by Stan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP23344: Fix space in seleucid temple pediment. This is against the art naming….
Nescio retitled this revision from fix space in actor file name to [art/actors] fix space in actor file name.May 18 2020, 10:14 AM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
actors/
props/
structures/
seleucids/
16 lines
16 lines
structures/
seleucids/
14 lines

Diff 10915

View Options

ps/trunk/binaries/data/mods/public/art/actors/props/structures/seleucids/temple pediment.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/structures/seleucids/temple_pediment.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/seleucids/temple.xml

Loading...
Wildfire Games · Phabricator