Page MenuHomeWildfire Games

[art/actors] standardize tower actor file names
Needs ReviewPublic

Authored by Nescio on Jan 9 2020, 12:22 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Currently different civs use different actor file names to refer to the same tower structure, which is inconsistent and confusing. This patch standardizes the file names:

  • wooden_tower, outpost_stone, sentry_towertower_small
  • fndn_wooden_towerfndn_tower_small
  • scout_tower, defense_tower_stone, defense_towertower_large
  • fndn_defense_towerfndn_tower_large
  • babylonian_towertower_babylonian

This is follows the same naming scheme as used by the recently added towers:

tower_artillery
tower_bolt
tower_double

and by the wall segments:

wall_gate
wall_long
wall_medium
wall_short
wall_tower

Related: D2551, D2553, D2554
Not done: remove unused kushites/defense_tower_wood.xml actor, which looks like the generic palisade fort.

Test Plan

Check for mistakes and omissions.

Event Timeline

Nescio created this revision.Jan 9 2020, 12:22 PM
Owners added a subscriber: Restricted Owners Package.Jan 9 2020, 12:22 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/987/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1505/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/83/display/redirect

Nescio edited the summary of this revision. (Show Details)Jan 9 2020, 2:32 PM
Nescio retitled this revision from standardize tower actor file names to [art/actors] standardize tower actor file names.May 18 2020, 10:15 AM

As written here -> https://code.wildfiregames.com/D3098#137968

I do feel like we should just abide by the AoE conventions of Watch Tower -> Guard Tower. 'Defense Tower' is just confusing. Small and Large are adequate but kind of boring, imo.