Page MenuHomeWildfire Games
Differential D2555

Fix missing phalanx animations
ClosedPublic
Actions

Authored by Silier on Jan 9 2020, 11:08 PM.

Details

Reviewers
None
Commits
rP23358: Fix missing phalanx animations
Summary

Fix missing phalanx animations following rP23293 because not correctly added in rP22718 required because of rP22442.

Test Plan

Check all units able to form phalanx do have phalanx animations.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Jan 9 2020, 11:08 PM
Owners added a subscriber: Restricted Owners Package.Jan 9 2020, 11:08 PM
Vulcan added a comment.Jan 9 2020, 11:10 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/995/display/redirect

Vulcan added a comment.Jan 9 2020, 11:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1513/display/redirect

Vulcan added a comment.Jan 9 2020, 11:13 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/91/display/redirect

Harbormaster completed remote builds in B10710: Diff 10951.Jan 9 2020, 11:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 10 2020, 10:33 AM
Closed by commit rP23358: Fix missing phalanx animations (authored by Silier). · Explain Why
This revision was automatically updated to reflect the committed changes.
Silier added a commit: rP23358: Fix missing phalanx animations.

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
actors/
units/
persians/
3 lines
ptolemies/
3 lines
3 lines
3 lines
seleucids/
3 lines
3 lines
3 lines

Diff 10958

View Options

ps/trunk/binaries/data/mods/public/art/actors/units/persians/infantry_spearman_c3.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/ptolemies/infantry_spearman_a.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/ptolemies/infantry_spearman_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/ptolemies/infantry_spearman_e.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/seleucids/infantry_spearman_a.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/seleucids/infantry_spearman_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/seleucids/infantry_spearman_e.xml

Loading...
Wildfire Games · Phabricator