Currently Display camera frustum shows both frustums: for camera and for shadows. The patch splits it.
Details
Details
- Reviewers
Stan - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23395: Splits debug display of frustums for an easier debugging of a culling and…
- Apply the patch and compile the game
- Run the game and turn on developer display
- Toggle "Display * Frustum" checkboxes
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 10782 Build 18760: Vulcan Build Jenkins Build 18759: Vulcan Build (macOS) Jenkins Build 18758: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1032/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
source/renderer/scripting/JSInterface_Renderer.h
| 1| /*·Copyright·(C)·2019·Wildfire·Games.
| | [NORMAL] LicenseYearBear:
| | License should have "2020" year instead of "2019"
source/renderer/scripting/JSInterface_Renderer.h
| 27| namespace·JSI_Renderer
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.
source/renderer/RenderingOptions.h
| 1| /*·Copyright·(C)·2019·Wildfire·Games.
| | [NORMAL] LicenseYearBear:
| | License should have "2020" year instead of "2019"
source/renderer/RenderingOptions.cpp
| 1| /*·Copyright·(C)·2019·Wildfire·Games.
| | [NORMAL] LicenseYearBear:
| | License should have "2020" year instead of "2019"
source/renderer/scripting/JSInterface_Renderer.cpp
| 1| /*·Copyright·(C)·2019·Wildfire·Games.
| | [NORMAL] LicenseYearBear:
| | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1550/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/128/display/redirect
Comment Actions
Please do not forget to post which parts were reviewed, which parts were tested when posting an acceptance.
Comment Actions
(or posting that you accept it so that he can close the revision proposal since it was committed in rP23395, to avoid ambiguity with an empty review)