Page MenuHomeWildfire Games

Splits debug display of frustums
ClosedPublic

Authored by vladislavbelov on Mon, Jan 13, 7:47 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23395: Splits debug display of frustums for an easier debugging of a culling and…
Summary

Currently Display camera frustum shows both frustums: for camera and for shadows. The patch splits it.

Test Plan
  1. Apply the patch and compile the game
  2. Run the game and turn on developer display
  3. Toggle "Display * Frustum" checkboxes

Event Timeline

vladislavbelov created this revision.Mon, Jan 13, 7:47 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1032/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/renderer/scripting/JSInterface_Renderer.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/scripting/JSInterface_Renderer.h
|  27| namespace·JSI_Renderer
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.

source/renderer/RenderingOptions.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/RenderingOptions.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/scripting/JSInterface_Renderer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1550/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/128/display/redirect

Stan accepted this revision.Mon, Jan 20, 11:25 AM
Stan added a subscriber: Stan.

Accepting so you can close.

This revision is now accepted and ready to land.Mon, Jan 20, 11:25 AM
In D2567#108291, @Stan wrote:

Accepting so you can close.

Thank you!

elexis added a subscriber: elexis.Mon, Jan 20, 11:51 AM

Please do not forget to post which parts were reviewed, which parts were tested when posting an acceptance.

(or posting that you accept it so that he can close the revision proposal since it was committed in rP23395, to avoid ambiguity with an empty review)

Stan added a comment.Mon, Jan 20, 12:05 PM

Feature is good, code looks good to me, and it works as expected.