Differential D2570

gui/manual/intro.txt use toggle
ClosedPublic
Actions

Authored by Nescio on Jan 15 2020, 12:00 PM.

Tags

None

Subscribers

Restricted Owners Package

Details

Reviewers

Gallaecio
Stan

Commits

rP23799: Replace various equivalent phrases (show/hide, enable/disable, open/close…

Summary

This patch is split from D2305. It replaces various equivalent phrases (show/hide, enable/disable, open/close, hide/show) with the word “toggle”, which is already used in a number of entries (e.g. lines 123 to 129), for consistency.
Also replaces two slashes (“/”) with “or” and another with “and” to reduce ambiguity
[EDIT] and replaces “Enter/Return” with “Enter (Return)”.

Test Plan

Check for mistakes and omissions, agree this is an improvement.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 15 2020, 12:00 PM

Owners added a subscriber: Restricted Owners Package.Jan 15 2020, 12:00 PM

Nescio added inline comments.Jan 15 2020, 12:03 PM

binaries/data/mods/public/gui/manual/intro.txt
65 ↗	(On Diff #11024)	This line is left unchanged, because using toggle here would probably obfuscate the entry.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1562/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1044/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/140/display/redirect

Harbormaster completed remote builds in B10803: Diff 11024.Jan 15 2020, 12:10 PM

Gallaecio accepted this revision.Jan 15 2020, 8:45 PM

Gallaecio added inline comments.

binaries/data/mods/public/gui/manual/intro.txt
62 ↗	(On Diff #11024)	“Open chat or send message”?
65 ↗	(On Diff #11024)	“or” then, maybe?

This revision is now accepted and ready to land.Jan 15 2020, 8:45 PM

Inline comments, Enter/Return.

binaries/data/mods/public/gui/manual/intro.txt
42 ↗	(On Diff #11043)	Because of line 62.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1056/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/152/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1574/display/redirect

Harbormaster completed remote builds in B10825: Diff 11043.Jan 15 2020, 9:34 PM

Changes look good and are harmless.

Closed by commit rP23799: Replace various equivalent phrases (show/hide, enable/disable, open/close… (authored by Stan). · Explain WhyJul 4 2020, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Stan added a commit: rP23799: Replace various equivalent phrases (show/hide, enable/disable, open/close….

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

manual/

22 lines

Diff 12543

ps/trunk/binaries/data/mods/public/gui/manual/intro.txt

Loading...