Page MenuHomeWildfire Games

gui/manual/intro.txt use toggle
AcceptedPublic

Authored by Nescio on Jan 15 2020, 12:00 PM.

Details

Reviewers
Gallaecio
Summary

This patch is split from D2305. It replaces various equivalent phrases (show/hide, enable/disable, open/close, hide/show) with the word “toggle”, which is already used in a number of entries (e.g. lines 123 to 129), for consistency.
Also replaces two slashes (“/”) with “or” and another with “and” to reduce ambiguity
[EDIT] and replaces “Enter/Return” with “Enter (Return)”.

Test Plan

Check for mistakes and omissions, agree this is an improvement.

Event Timeline

Nescio created this revision.Jan 15 2020, 12:00 PM
Owners added a subscriber: Restricted Owners Package.Jan 15 2020, 12:00 PM
Nescio added inline comments.Jan 15 2020, 12:03 PM
binaries/data/mods/public/gui/manual/intro.txt
65

This line is left unchanged, because using toggle here would probably obfuscate the entry.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1562/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1044/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/140/display/redirect

Gallaecio accepted this revision.Jan 15 2020, 8:45 PM
Gallaecio added inline comments.
binaries/data/mods/public/gui/manual/intro.txt
62

“Open chat or send message”?

65

“or” then, maybe?

This revision is now accepted and ready to land.Jan 15 2020, 8:45 PM
Nescio updated this revision to Diff 11043.Jan 15 2020, 9:30 PM
Nescio edited the summary of this revision. (Show Details)

Inline comments, Enter/Return.

binaries/data/mods/public/gui/manual/intro.txt
42

Because of line 62.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1056/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/152/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1574/display/redirect