Page MenuHomeWildfire Games
Differential D2579

standardize armor technology tooltips
ClosedPublic
Actions

Authored by Nescio on Jan 18 2020, 1:08 PM.

Details

Reviewers
Gallaecio
Freagarach
Commits
rP23937: Standardise armour technology tooltips.
Summary

This patch standardizes the tooltips for technologies that modify the armour.
Aura tooltips were already standardized last year.

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 18 2020, 1:08 PM
Vulcan added a comment.Jan 18 2020, 1:10 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1082/display/redirect

Vulcan added a comment.Jan 18 2020, 1:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/178/display/redirect

Vulcan added a comment.Jan 18 2020, 1:13 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1600/display/redirect

Harbormaster completed remote builds in B10867: Diff 11091.Jan 18 2020, 1:13 PM
Gallaecio accepted this revision.Jan 19 2020, 9:46 AM
This revision is now accepted and ready to land.Jan 19 2020, 9:46 AM
Nescio updated this revision to Diff 12697.Jul 15 2020, 6:39 PM
  • rebased
Owners added a subscriber: Restricted Owners Package.Jul 15 2020, 6:39 PM
Nescio edited subscribers, added: Stan; removed: Restricted Owners Package.Jul 15 2020, 6:39 PM
Nescio updated this revision to Diff 12698.Jul 15 2020, 6:42 PM
  • minus sign
Owners added a subscriber: Restricted Owners Package.Jul 15 2020, 6:42 PM
Nescio removed a subscriber: Restricted Owners Package.Jul 15 2020, 6:42 PM
Vulcan added a comment.Jul 15 2020, 6:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2653/display/redirect

Vulcan added a comment.Jul 15 2020, 6:47 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2654/display/redirect

Harbormaster completed remote builds in B12416: Diff 12697.Jul 15 2020, 6:57 PM
Harbormaster completed remote builds in B12417: Diff 12698.Jul 15 2020, 7:16 PM
Nescio mentioned this in D2892: clean up market and other structure classes.Jul 21 2020, 10:02 PM
Nescio updated this revision to Diff 12999.Aug 1 2020, 9:56 PM
  • rebased
Owners added a subscriber: Restricted Owners Package.Aug 1 2020, 9:56 PM
Vulcan added a comment.Aug 1 2020, 10:01 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2836/display/redirect

Harbormaster completed remote builds in B12692: Diff 12999.Aug 1 2020, 10:14 PM
Freagarach accepted this revision.Aug 6 2020, 8:00 AM
Freagarach added a subscriber: Freagarach.
  • Grepped for completeness.
  • Change is nice, extra info is found in description.
Closed by commit rP23937: Standardise armour technology tooltips. (authored by Freagarach). · Explain WhyAug 6 2020, 8:05 AM
This revision was automatically updated to reflect the committed changes.
Freagarach added a commit: rP23937: Standardise armour technology tooltips..

Revision Contents
Changeset List

Diff 13090

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_cav_01.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_cav_02.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_hero_01.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_infantry_01.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_infantry_02.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_ship_hullsheathing.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_ship_hypozomata.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/armor_ship_reinforcedhull.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/trade_convoys_armor.json

Loading...
Wildfire Games · Phabricator