Page MenuHomeWildfire Games

display centre before house
ClosedPublic

Authored by Nescio on Jan 18 2020, 2:25 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23548: Display Civic Center before houses
Summary

The civic centre is arguably the most important structure in game: it has a territory root and a significant territory influence radius, is a dropsite for all resources, provides population, trains workers, and researches phase technologies. Besides, it is the starting structure and the first thing to build in nomad games. Therefore I think it ought to be displayed first.
The order in which entities are displayed depends on the order they're listed in the build and production lists in the templates; there are currently about a dozen structures before the civic centre.
This patch lists the centre, crannog, and colony first, before the house etc.
How it looks in the structure tree:


How it looks in a game sesssion:

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 18 2020, 2:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1084/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/180/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1602/display/redirect

I agree that the CC ought to be placed first. Not sure though that the crannog, which is a Briton-specific structure, should be placed in the general build-list.
+1 on the Military Colony.

The crannog and colony are fundamentally centres and should thus be listed together.
And it'll only show up to those civs that actually have the template, if that's what you meant.

Hello, yes i think CC, should be colocated in first place, but, following that order, then some more buildings maybe should be changed too.
Greetings

Stan added a subscriber: Stan.Thu, Mar 19, 12:23 PM

@Stockfish0ad can you elaborate on which one you'd like to change?

@Stan _ CC, Storehouse, Farmhouse, House, Farm, Barrack, Minitower, Vision Tower, Mini CC (if any), Market, Tower, Temple - Armery (i don't know how to order them),..... Stable, Darsena (i try to order them by priority and useness.)

_ CC, Storehouse, Farmhouse, House, Farm, Barrack, Minitower, Vision Tower, Mini CC (if any), Market, Tower, Temple - Armery (i don't know how to order them),..... Stable, Darsena (i try to order them by priority and useness.)

I don't think any other changes other than moving the CCs are necessary. I don't think moving the house after storehouses and farmsteads makes much sense as houses are the most frequently made building. In general I believe that buildings should be placed in such a way which makes the most sense to new and casual players, because people who want to play more competitively will switch to using hotkeys for buildings instead of slowly clicking on them.

Stan accepted this revision.Sat, Mar 21, 2:53 PM

I agree with the change as well, and I think this will be an improvement.

It is also harmless and a nice cleanup. Thanks @ValihrAnt and @Stockfish0ad

This revision is now accepted and ready to land.Sat, Mar 21, 2:53 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Wed, Mar 25, 12:46 PM