Page MenuHomeWildfire Games

update hero icons and names
ClosedPublic

Authored by Nescio on Jan 19 2020, 12:09 PM.

Details

Summary

This patch:

  • sets a generic icon (the golden laurel wreath) in template_unit_hero.xml
  • removes icons from hero templates that used one belonging to another hero
  • corrects hero icons, generic names, and specific names where necessary
Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 19 2020, 12:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1611/display/redirect

Stan added inline comments.Jan 19 2020, 1:16 PM
binaries/data/mods/public/simulation/templates/units/iber_hero_indibil_infantry.xml
9 ↗(On Diff #11107)

Why?

binaries/data/mods/public/simulation/templates/units/mace_hero_philip_pike.xml
11 ↗(On Diff #11107)

Why?

Nescio added inline comments.Jan 19 2020, 1:33 PM
binaries/data/mods/public/simulation/templates/units/iber_hero_indibil_infantry.xml
9 ↗(On Diff #11107)

Because it's clearly a cavalry icon, check it yourself.

binaries/data/mods/public/simulation/templates/units/mace_hero_philip_pike.xml
11 ↗(On Diff #11107)

idem

Stan accepted this revision.Jan 19 2020, 2:29 PM
Stan added inline comments.
binaries/data/mods/public/simulation/templates/units/iber_hero_indibil_infantry.xml
9 ↗(On Diff #11107)

I assumed it would be good enough :)

This revision is now accepted and ready to land.Jan 19 2020, 2:29 PM
This revision was automatically updated to reflect the committed changes.