Page MenuHomeWildfire Games

Simple cleanup of ModelRenderer
ClosedPublic

Authored by vladislavbelov on Jan 26 2020, 3:09 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23445: Adds const to Material and CShaderProgram::Binding methods, removes a redundant…
Summary

Adds const and remove redundant variable.

Test Plan
  1. Apply the patch and compile the game
  2. Run a map like Deep Forest
  3. Compare frame time with the game before the patch

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jan 26 2020, 3:09 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1658/display/redirect

Stan added a subscriber: Stan.EditedJan 26 2020, 1:14 PM

No difference whatsoever for me on a very large deep forest map.

For some reason it was slower in units_demo 55vs45 , but it eventually went to the same perf (45)If it wasn't that jumpy it would be easier to tell.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2020, 10:32 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.