Adds const and remove redundant variable.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23445: Adds const to Material and CShaderProgram::Binding methods, removes a redundant…
- Apply the patch and compile the game
- Run a map like Deep Forest
- Compare frame time with the game before the patch
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1658/display/redirect
Comment Actions
No difference whatsoever for me on a very large deep forest map.
For some reason it was slower in units_demo 55vs45 , but it eventually went to the same perf (45)If it wasn't that jumpy it would be easier to tell.