glGetError may lead to a synchronization during rendering process. But we want to interrupt client/driver/GPU as less as possible.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23462: Moves GL error check after SwapBuffers to decrease a possible synchronization…
- Apply the patch and compile the game
- Run the game
- Check that the game doesn't produce new errors
- Try to resize a window to a really strange size (like 100x900) to generate an error
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/main.cpp | 0| } | | [NORMAL] CPPCheckBear (toomanyconfigs): | | Too many #ifdef configurations - cppcheck only checks 12 configurations. Use --force to check all configurations. For more details, use --enable=information. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1664/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/renderer/Renderer.h | 69| class·CRenderer·: | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCRenderer:' is invalid C code. Use --std or --language to configure the language. source/main.cpp | 0| } | | [NORMAL] CPPCheckBear (toomanyconfigs): | | Too many #ifdef configurations - cppcheck only checks 12 configurations. Use --force to check all configurations. For more details, use --enable=information. source/tools/atlas/GameInterface/View.cpp | 211| » » //·not·in·every·call·to·g_Game->Update | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1682/display/redirect