Page MenuHomeWildfire Games
Differential D2602

Rephrase formation disabled tooltip after rP23450
ClosedPublic
Actions

Authored by Silier on Jan 28 2020, 8:21 PM.

Details

Reviewers
Nescio
Commits
rP23466: Rephrase formation disabled tooltip after rP23450
Summary

I failed to keep tooltip constancy in rP23450 done in rP22498 as I did not recheck tooltip changes when revisiting D1462 after longer time.

Test Plan

Check tooltip is correct.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Jan 28 2020, 8:21 PM
Vulcan added a comment.Jan 28 2020, 8:26 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1674/display/redirect

Harbormaster completed remote builds in B10986: Diff 11207.Jan 28 2020, 8:26 PM
Nescio accepted this revision.Jan 28 2020, 10:21 PM

Thanks.

This revision is now accepted and ready to land.Jan 28 2020, 10:21 PM
Closed by commit rP23466: Rephrase formation disabled tooltip after rP23450 (authored by Silier). · Explain WhyJan 30 2020, 10:09 PM
This revision was automatically updated to reflect the committed changes.
Silier added a commit: rP23466: Rephrase formation disabled tooltip after rP23450.

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
civs/
4 lines
4 lines
4 lines
4 lines
templates/
special/
formations/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 11232

View Options

ps/trunk/binaries/data/mods/public/simulation/data/civs/brit.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/civs/gaul.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/civs/iber.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/civs/maur.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/anti_cavalry.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/phalanx.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/skirmish.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/testudo.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/wedge.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml

Loading...
Wildfire Games · Phabricator