Apparently “up” and “down” are confusing terms. At least in the game setup, the Tab hotkeys do the opposite of what the tooltip suggests. This patch improves the function names and the tooltip strings.
Before:
After:
Details
Details
- Reviewers
bb - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23721: Correct tooltips of gamesetupSettingsTabs
After:
Launch the game, open the match setup, click on Map/Player/Game Type, read the tooltip, press the hotkey (Tab), and observe what happens.
Apply the patch and repeat the above.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1707/display/redirect
Comment Actions
I agree with the proposed string changes being a more clear description, but I wonder where we transifex is in translation coverage currently (whether they keep up with translations as fast as we introduce or change strings).
| binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameSettingsTabs.js | ||
|---|---|---|
| 85 ↗ | (On Diff #11266) | You are correct, in this line up should be prev, not next (and next prev), from rP23374. (And the order in which they the tooltips were printed is correct.) |
| binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameSettingsTabs.js | ||
|---|---|---|
| 15–16 ↗ | (On Diff #11266) | I think these two should be interchanged |