Differential D2618

Remove some false positives from checkrefs --unused options
AbandonedPublic
Actions

Authored by Stan on Feb 5 2020, 12:40 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

A few files reported by chekrefs are false positives. This patch adresses some of those. see P194

TODO: The GUI can now have includes in any subobject while it could only do so in page_*.xml files at the root level (Notice also that we now have two way to do includes)

Music defined by music.js are marked unused by the script, moving them to a JSON could be nice.
Alphamaps are hardcoded in C++, moving them to a JSON could be nice.

Test Plan

Run the script, see that it removes false positives namingly

Some Selection textures
Some missing healing auras reported by @Nescio
Some GUI files.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 11053
Build 19596: Vulcan Build	Jenkins
Build 19595: Vulcan Build (macOS)	Jenkins
Build 19594: Vulcan Build (Windows)	Jenkins

Event Timeline

Stan created this revision.Feb 5 2020, 12:40 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1713/display/redirect

Harbormaster completed remote builds in B11053: Diff 11276.Feb 5 2020, 12:46 AM

Stan mentioned this in rP23520: Check for missing selection textures and missing range overlay textures.Mar 7 2020, 12:07 PM

Should be done in D2849

Revision Contents
Changeset List

Path

Size

source/

tools/

entity/

33 lines

Diff 11276

source/tools/entity/checkrefs.pl

Loading...