Page MenuHomeWildfire Games

Adds GLSL shaders of overlay lines
Needs ReviewPublic

Authored by vladislavbelov on Feb 5 2020, 4:52 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

We were using ARB shaders in GLSL mode for overlay lines (unit selection, ranges, ...).

Test Plan
  1. Apply the patch and compile the game
  2. Run the game
  3. Check that there's no significant differences for overlay lines (selections, ranges, ...) with/without "Prefer GLSL"

Event Timeline

vladislavbelov created this revision.Feb 5 2020, 4:52 PM
Vulcan added a comment.Feb 5 2020, 4:57 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1717/display/redirect

vladislavbelov edited the test plan for this revision. (Show Details)Feb 6 2020, 10:51 AM

The game does run without problems. I can't recognize any difference between with/without "Prefer GLSL".

For me, on Lubuntu 18.04, also no difference observed.

Stan added a subscriber: Stan.Apr 27 2020, 8:17 AM

I don't see any difference either.

OS             : Linux 5.3.0-42-generic (#34~18.04.1-Ubuntu SMP Fri Feb 28 13:42:26 UTC 2020)
CPU            : x86_64, Intel Core i5-4300U @ 1.90GHz (1x2x2), 2.49 GHz
Memory         : 7882 MiB; 1059 MiB free
Graphics Card  : Intel Open Source Technology Center Mesa DRI Intel(R) Haswell Mobile 
OpenGL Drivers : 3.0 Mesa 19.2.8; OpenGL 3.0 Mesa 19.2.8
Video Mode     : 1920x1080:24
Sound Card     : Audio interne Stéréo analogique; 
Sound Drivers  : 1.1 ALSOFT 1.18.2

think you should go ahead and commit this one earlier rather than later @vladislavbelov