We were using ARB shaders in GLSL mode for overlay lines (unit selection, ranges, ...).
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23765: Adds GLSL shaders of overlay lines.
- Apply the patch and compile the game
- Run the game
- Check that there's no significant differences for overlay lines (selections, ranges, ...) with/without "Prefer GLSL"
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1717/display/redirect
Comment Actions
The game does run without problems. I can't recognize any difference between with/without "Prefer GLSL".
Comment Actions
I don't see any difference either.
OS : Linux 5.3.0-42-generic (#34~18.04.1-Ubuntu SMP Fri Feb 28 13:42:26 UTC 2020) CPU : x86_64, Intel Core i5-4300U @ 1.90GHz (1x2x2), 2.49 GHz Memory : 7882 MiB; 1059 MiB free Graphics Card : Intel Open Source Technology Center Mesa DRI Intel(R) Haswell Mobile OpenGL Drivers : 3.0 Mesa 19.2.8; OpenGL 3.0 Mesa 19.2.8 Video Mode : 1920x1080:24 Sound Card : Audio interne Stéréo analogique; Sound Drivers : 1.1 ALSOFT 1.18.2
Comment Actions
think you should go ahead and commit this one earlier rather than later @vladislavbelov