Page MenuHomeWildfire Games

[art/actors] remove ground texture from brit and cart gate actors
ClosedPublic

Authored by Nescio on Feb 15 2020, 11:08 AM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23502: Remove ground texture from brit and cart gate actors as it doesn't fit all the…
Summary

This patch removes the ground texture from the Briton and Carthaginian gate actors, to improve consistencies, because other gates and wall segments don't have that either.

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 15 2020, 11:08 AM
Owners added a subscriber: Restricted Owners Package.Feb 15 2020, 11:08 AM
Stan added a comment.Feb 15 2020, 11:10 AM

Why not add them to the others instead?

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1766/display/redirect

Because this is the lesser changes and because the texture doesn't look good on all terrains.

Stan added a comment.Feb 15 2020, 11:20 AM

Do you have an example where it looks bad?


The first terrain I tried. I could probably find even better (i.e. worse) examples.

Stan added a comment.Feb 15 2020, 11:25 AM

We have the problem with a lot of decals, don't we?

If the texture is about as large as the structure, it isn't too bad:


But for gates, the area of the painted terrain is much larger than the footprint of the gate.

Stan accepted this revision.Feb 15 2020, 11:32 AM

Fair enough.

This revision is now accepted and ready to land.Feb 15 2020, 11:32 AM
Nescio retitled this revision from remove ground texture from brit and cart gate actors to [art/actors] remove ground texture from brit and cart gate actors.May 18 2020, 10:16 AM