Differential D2635

[art/actors] remove elephant prop from pers hall actor
ClosedPublic
Actions

Authored by Nescio on Feb 15 2020, 11:26 AM.

Tags

None

Subscribers

Restricted Owners Package

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23523: Remove elephant prop from pers hall actor for consistency and better immersion.

Summary

This patch removes the Indian elephant prop from the Persian Hall actor, because:

it's only visible from certain angles;
the elephant is larger than the doors of the structure, breaking immersion;
cart, kush, ptol, and sele fortresses don't have visible elephants either;
rP21314.

Test Plan

Agree this is an improvement.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 15 2020, 11:26 AM

Owners added a subscriber: Restricted Owners Package.Feb 15 2020, 11:26 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1768/display/redirect

Harbormaster completed remote builds in B11135: Diff 11361.Feb 15 2020, 11:30 AM

Stan accepted this revision.Mar 7 2020, 3:52 PM

This revision is now accepted and ready to land.Mar 7 2020, 3:52 PM

Closed by commit rP23523: Remove elephant prop from pers hall actor for consistency and better immersion. (authored by Stan). · Explain WhyMar 7 2020, 3:54 PM

This revision was automatically updated to reflect the committed changes.

Stan added a commit: rP23523: Remove elephant prop from pers hall actor for consistency and better immersion..

Nescio retitled this revision from remove elephant prop from pers hall actor to [art/actors] remove elephant prop from pers hall actor.May 18 2020, 10:16 AM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

art/

actors/

structures/

persians/

3 lines

Diff 11462

ps/trunk/binaries/data/mods/public/art/actors/structures/persians/hall.xml

Loading...