Page MenuHomeWildfire Games

move iberian cavalry swordsman actors
ClosedPublic

Authored by Nescio on Feb 15 2020, 12:31 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23552: Move iberian cavalry swordsman actors to the iberian folder.
Summary

Currently:

  • units/cart_cavalry_swordsman_gaul_* templates use units/gauls/cavalry_swordsman_* actors
  • units/cart_infantry_swordsman_gaul_* templates use units/gauls/infantry_swordsman_* actors
  • units/cart_infantry_javelinist_iber_* templates use units/iberians/infantry_javelinist_* actors
  • units/cart_infantry_slinger_iber_* templates use units/iberians/infantry_slinger_* actors

However, the units/cart_cavalry_swordsman_iber_* templates use units/carthaginians/cavalry_swordsman_* actors. This patch moves those to the iberians/ folder for consistency and to avoid potential, future duplication.

Test Plan

Agree this is an improvement, check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 15 2020, 12:31 PM
Owners added a subscriber: Restricted Owners Package.Feb 15 2020, 12:31 PM
Nescio edited the summary of this revision. (Show Details)Feb 15 2020, 12:31 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1769/display/redirect

Sounds good for me, is the same move i've done with gauls mercenaries before when updated those.

No objections.

@Stan

Stan accepted this revision.Wed, Mar 25, 11:57 PM
This revision is now accepted and ready to land.Wed, Mar 25, 11:57 PM

Forgot accept message again (wink @Freagarach) Patch is good, and I agree that iberian units belong to the iberian folder. There is no gameplay change, rather it's an organisational one, therefore it has little impact. Might ping @wowgetoffyourcellphone so he can update his mod accordingly.

This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Thu, Mar 26, 12:06 AM