Page MenuHomeWildfire Games

adjust ptol military colony footprint

Authored by Nescio on Feb 17 2020, 6:42 PM.



The footprint of the Ptolemaic military colony is visibly much larger than its actor, and seems to be based on the civic centre. This patch corrects it.
Before (ptol left, sele right):

After (ptol left, sele right):

Test Plan

Check for typos.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 17 2020, 6:42 PM
Nescio added inline comments.
13 ↗(On Diff #11384)

Footprint minus 2.

4–5 ↗(On Diff #11384)

Removing trailing zeros, per D2280.

22–25 ↗(On Diff #11384)

Removing because each of its children has different values.

Successful build - Chance fights ever on the side of the prudent.

Link to build:

bb accepted this revision.Feb 17 2020, 6:56 PM

Correct and complete, no need to let this rot

This revision is now accepted and ready to land.Feb 17 2020, 6:56 PM
bb added inline comments.Feb 17 2020, 6:59 PM
22–25 ↗(On Diff #11384)

also important to not that the parent already has some value assigned.

This revision was automatically updated to reflect the committed changes.

That's quick, thanks!
D2502 (quite large) is still waiting, and there is also D2496 (much smaller).