The footprint of the Ptolemaic military colony is visibly much larger than its actor, and seems to be based on the civic centre. This patch corrects it.
Before (ptol left, sele right):
After (ptol left, sele right):
Details
Details
- Reviewers
bb - Commits
- rP23504: Correct military colony footprint/obstruction
After (ptol left, sele right):
Check for typos.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| binaries/data/mods/public/simulation/templates/structures/ptol_military_colony.xml | ||
|---|---|---|
| 13 ↗ | (On Diff #11384) | Footprint minus 2. |
| binaries/data/mods/public/simulation/templates/structures/sele_military_colony.xml | ||
| 4–5 ↗ | (On Diff #11384) | Removing trailing zeros, per D2280. |
| binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre_military_colony.xml | ||
| 22–25 ↗ | (On Diff #11384) | Removing because each of its children has different values. |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1783/display/redirect
| binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre_military_colony.xml | ||
|---|---|---|
| 22–25 ↗ | (On Diff #11384) | also important to not that the parent already has some value assigned. |