nothing special
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
Hello, thanks for the contribution! This should be already fixed by D2523, which is not yet committed. Could you take a look and check that it works? Else I'll update that other diff.
Regarding the SDK change: feel free to apply it locally but we will not commit such a change, as we want to remain compatible with old versions of OSX as long as possible.
Regarding the localized display name: is it accurate to set this to true? I agree that 0 A.D. should be fine for everyone but it isn't actually localized. Could you point to a reference explaining whether we should use it? If we should, I'll add it to D2523.
Thanks again!
Comment Actions
Regarding the SDK change: I understand the goal, but that misses the goal. D2523 has a solution.
Regarding the localized display name: It does not say the programm itself is localized. It just enables the ability to display the bundle’s name as 0 A.D. while its real filename is 0ad.app. My code creates one InfoPlist.strings in Resources/ which macOS will use independent from any language settings. This is a common practice to avoid non-ASCII characters or spaces in bundle-filenames. I did this because the bundle-filenames of the later offical mac releases changed several times. It is to avoid bundle-filenames like 0 A.D..app (which was ok) or 0 A.D.app (which wasn’t). Whether you should use this or not can’t tell you
D2523 uses "0 A.D..app" as bundle-filename and does not make use of Display Name. So, my changes regarding this may be applied after D2523 was committed.
Comment Actions
I see! Thanks for the info. I'll include your changes in the other patch then 👍
Regarding the previous releases and inconsistencies of filenames: sorry about that, from now on we should be fine thanks to our new build platform.
Comment Actions
Cool!
I found some other minors I would submit after commit (’m still confused by svn&git)
Comment Actions
Don't hesitate to ask questions on IRC :)
Thanks for your help yesterday. I had to understand that there is no diff when I already commited my changes, so I re-created may dummy 0ad repo and could write my diff-file.