Page MenuHomeWildfire Games

Explicitly return "undefined" when requesting Splash data in Attack.js.
ClosedPublic

Authored by Freagarach on Mar 24 2020, 2:40 PM.

Details

Reviewers
Angen
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23563: Explicitly return "undefined" when requesting Splash data in Attack.js
Test Plan

Verify that nothing breaks.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Mar 24 2020, 2:40 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1897/display/redirect

Angen accepted this revision.Mar 29 2020, 2:40 PM
Angen added a subscriber: Angen.

Compared to other occurrences in code base, it makes sense to return undefined rather then just empty return.

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions, return value of empty return is undefined so there is no problem with this change in code and logic level.

This revision is now accepted and ready to land.Mar 29 2020, 2:40 PM