Page MenuHomeWildfire Games

Add simple test for XP trickle.
ClosedPublic

Authored by Freagarach on Mar 25 2020, 8:35 PM.

Details

Reviewers
bb
Summary

In rP23541 a XP trickle was added, this adds a unit test for that.

Test Plan

Run test, look if it should be expanded.

Event Timeline

Freagarach created this revision.Mar 25 2020, 8:35 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1909/display/redirect

Stan added a subscriber: Stan.Mar 25 2020, 11:56 PM

Nice! Might be good to check one can also promote a unit using that. Mayb unify the test dunno.
Maybe TestExperienceTrickle?

Freagarach updated this revision to Diff 11556.Mar 26 2020, 8:37 AM

Also test promotion itself.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  50|  50| 
|  51|  51| (function testMultipleXPIncrease()
|  52|  52| {
|  53|    |-	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|    |  53|+cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  54|  54| 		"Entity": "template_b",
|  55|  55| 		"RequiredXp": 1000
|  56|  56| 	});
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  51|  51| (function testMultipleXPIncrease()
|  52|  52| {
|  53|  53| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  54|    |-		"Entity": "template_b",
|    |  54|+	"Entity": "template_b",
|  55|  55| 		"RequiredXp": 1000
|  56|  56| 	});
|  57|  57| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  52|  52| {
|  53|  53| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  54|  54| 		"Entity": "template_b",
|  55|    |-		"RequiredXp": 1000
|    |  55|+	"RequiredXp": 1000
|  56|  56| 	});
|  57|  57| 
|  58|  58| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  53|  53| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  54|  54| 		"Entity": "template_b",
|  55|  55| 		"RequiredXp": 1000
|  56|    |-	});
|    |  56|+});
|  57|  57| 
|  58|  58| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  59|  59| 	cmpPromotion.IncreaseXp(200);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  55|  55| 		"RequiredXp": 1000
|  56|  56| 	});
|  57|  57| 
|  58|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    |  58|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  59|  59| 	cmpPromotion.IncreaseXp(200);
|  60|  60| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  61|  61| 	cmpPromotion.IncreaseXp(800);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  56|  56| 	});
|  57|  57| 
|  58|  58| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  59|    |-	cmpPromotion.IncreaseXp(200);
|    |  59|+cmpPromotion.IncreaseXp(200);
|  60|  60| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  61|  61| 	cmpPromotion.IncreaseXp(800);
|  62|  62| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  57|  57| 
|  58|  58| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  59|  59| 	cmpPromotion.IncreaseXp(200);
|  60|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|    |  60|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  61|  61| 	cmpPromotion.IncreaseXp(800);
|  62|  62| 
|  63|  63| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  58|  58| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  59|  59| 	cmpPromotion.IncreaseXp(200);
|  60|  60| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  61|    |-	cmpPromotion.IncreaseXp(800);
|    |  61|+cmpPromotion.IncreaseXp(800);
|  62|  62| 
|  63|  63| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|  64|  64| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  60|  60| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  61|  61| 	cmpPromotion.IncreaseXp(800);
|  62|  62| 
|  63|    |-	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|    |  63|+TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|  64|  64| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  65|  65| 	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  61|  61| 	cmpPromotion.IncreaseXp(800);
|  62|  62| 
|  63|  63| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|  64|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    |  64|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  65|  65| 	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|  67|  67| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  62|  62| 
|  63|  63| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|  64|  64| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  65|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|    |  65|+TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|  67|  67| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|  68|  68| 	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  63|  63| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|  64|  64| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  65|  65| 	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|    |-	cmpPromotion.IncreaseXp(4200);
|    |  66|+cmpPromotion.IncreaseXp(4200);
|  67|  67| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|  68|  68| 	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|  69|  69| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  64|  64| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  65|  65| 	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|  67|    |-	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|    |  67|+TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|  68|  68| 	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|  69|  69| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  70|  70| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  65|  65| 	TS_ASSERT_EQUALS(cmpPromotion.GetRequiredXp(), 1000);
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|  67|  67| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|  68|    |-	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|    |  68|+TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|  69|  69| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  70|  70| 
|  71|  71| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  66|  66| 	cmpPromotion.IncreaseXp(4200);
|  67|  67| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 62);
|  68|  68| 	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|  69|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|    |  69|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  70|  70| 
|  71|  71| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  72|  72| 		"Entity": "template_b",
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  68|  68| 	TS_ASSERT_EQUALS(cmpPromotion.template.Entity, "end");
|  69|  69| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  70|  70| 
|  71|    |-	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|    |  71|+cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  72|  72| 		"Entity": "template_b",
|  73|  73| 		"RequiredXp": 1000
|  74|  74| 	});
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  69|  69| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 200);
|  70|  70| 
|  71|  71| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  72|    |-		"Entity": "template_b",
|    |  72|+	"Entity": "template_b",
|  73|  73| 		"RequiredXp": 1000
|  74|  74| 	});
|  75|  75| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  70|  70| 
|  71|  71| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  72|  72| 		"Entity": "template_b",
|  73|    |-		"RequiredXp": 1000
|    |  73|+	"RequiredXp": 1000
|  74|  74| 	});
|  75|  75| 
|  76|  76| 	let cmpHealth = AddMock(ENT_ID, IID_Health, {
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  71|  71| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  72|  72| 		"Entity": "template_b",
|  73|  73| 		"RequiredXp": 1000
|  74|    |-	});
|    |  74|+});
|  75|  75| 
|  76|  76| 	let cmpHealth = AddMock(ENT_ID, IID_Health, {
|  77|  77| 		"GetHitpoints": () => 0,
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  73|  73| 		"RequiredXp": 1000
|  74|  74| 	});
|  75|  75| 
|  76|    |-	let cmpHealth = AddMock(ENT_ID, IID_Health, {
|    |  76|+let cmpHealth = AddMock(ENT_ID, IID_Health, {
|  77|  77| 		"GetHitpoints": () => 0,
|  78|  78| 	});
|  79|  79| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  74|  74| 	});
|  75|  75| 
|  76|  76| 	let cmpHealth = AddMock(ENT_ID, IID_Health, {
|  77|    |-		"GetHitpoints": () => 0,
|    |  77|+	"GetHitpoints": () => 0,
|  78|  78| 	});
|  79|  79| 
|  80|  80| 	cmpPromotion.IncreaseXp(1000);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  75|  75| 
|  76|  76| 	let cmpHealth = AddMock(ENT_ID, IID_Health, {
|  77|  77| 		"GetHitpoints": () => 0,
|  78|    |-	});
|    |  78|+});
|  79|  79| 
|  80|  80| 	cmpPromotion.IncreaseXp(1000);
|  81|  81| 	TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  77|  77| 		"GetHitpoints": () => 0,
|  78|  78| 	});
|  79|  79| 
|  80|    |-	cmpPromotion.IncreaseXp(1000);
|    |  80|+cmpPromotion.IncreaseXp(1000);
|  81|  81| 	TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|  82|  82| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  83|  83| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  78|  78| 	});
|  79|  79| 
|  80|  80| 	cmpPromotion.IncreaseXp(1000);
|  81|    |-	TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|    |  81|+TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|  82|  82| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  83|  83| 
|  84|  84| 	DeleteMock(ENT_ID, IID_Health);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  79|  79| 
|  80|  80| 	cmpPromotion.IncreaseXp(1000);
|  81|  81| 	TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|  82|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    |  82|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  83|  83| 
|  84|  84| 	DeleteMock(ENT_ID, IID_Health);
|  85|  85| })();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  81|  81| 	TS_ASSERT_EQUALS(cmpPromotion.entity, ENT_ID);
|  82|  82| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  83|  83| 
|  84|    |-	DeleteMock(ENT_ID, IID_Health);
|    |  84|+DeleteMock(ENT_ID, IID_Health);
|  85|  85| })();
|  86|  86| 
|  87|  87| (function testExperienceTrickle()
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  86|  86| 
|  87|  87| (function testExperienceTrickle()
|  88|  88| {
|  89|    |-	let cmpTimer = ConstructComponent(SYSTEM_ENTITY, "Timer", {});
|    |  89|+let cmpTimer = ConstructComponent(SYSTEM_ENTITY, "Timer", {});
|  90|  90| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  91|  91| 		"Entity": "template_b",
|  92|  92| 		"RequiredXp": "100",
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  87|  87| (function testExperienceTrickle()
|  88|  88| {
|  89|  89| 	let cmpTimer = ConstructComponent(SYSTEM_ENTITY, "Timer", {});
|  90|    |-	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|    |  90|+cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  91|  91| 		"Entity": "template_b",
|  92|  92| 		"RequiredXp": "100",
|  93|  93| 		"TrickleRate": "10"
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  88|  88| {
|  89|  89| 	let cmpTimer = ConstructComponent(SYSTEM_ENTITY, "Timer", {});
|  90|  90| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  91|    |-		"Entity": "template_b",
|    |  91|+	"Entity": "template_b",
|  92|  92| 		"RequiredXp": "100",
|  93|  93| 		"TrickleRate": "10"
|  94|  94| 	});
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  89|  89| 	let cmpTimer = ConstructComponent(SYSTEM_ENTITY, "Timer", {});
|  90|  90| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  91|  91| 		"Entity": "template_b",
|  92|    |-		"RequiredXp": "100",
|    |  92|+	"RequiredXp": "100",
|  93|  93| 		"TrickleRate": "10"
|  94|  94| 	});
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 1 tab but found 2.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  90|  90| 	cmpPromotion = ConstructComponent(ENT_ID, "Promotion", {
|  91|  91| 		"Entity": "template_b",
|  92|  92| 		"RequiredXp": "100",
|  93|    |-		"TrickleRate": "10"
|    |  93|+	"TrickleRate": "10"
|  94|  94| 	});
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  91|  91| 		"Entity": "template_b",
|  92|  92| 		"RequiredXp": "100",
|  93|  93| 		"TrickleRate": "10"
|  94|    |-	});
|    |  94|+});
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  92|  92| 		"RequiredXp": "100",
|  93|  93| 		"TrickleRate": "10"
|  94|  94| 	});
|  95|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|    |  95|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  93|  93| 		"TrickleRate": "10"
|  94|  94| 	});
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|    |-	cmpTimer.OnUpdate({ "turnLength": 1 });
|    |  96|+cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  94|  94| 	});
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|    |  97|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100| 100| 	cmpTimer.OnUpdate({ "turnLength": 8 });
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  95|  95| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 0);
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|    |-	cmpTimer.OnUpdate({ "turnLength": 2 });
|    |  98|+cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100| 100| 	cmpTimer.OnUpdate({ "turnLength": 8 });
| 101| 101| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  96|  96| 	cmpTimer.OnUpdate({ "turnLength": 1 });
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
|    |  99|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100| 100| 	cmpTimer.OnUpdate({ "turnLength": 8 });
| 101| 101| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
| 102| 102| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  97|  97| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100|    |-	cmpTimer.OnUpdate({ "turnLength": 8 });
|    | 100|+cmpTimer.OnUpdate({ "turnLength": 8 });
| 101| 101| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
| 102| 102| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
| 103| 103| })();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  98|  98| 	cmpTimer.OnUpdate({ "turnLength": 2 });
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100| 100| 	cmpTimer.OnUpdate({ "turnLength": 8 });
| 101|    |-	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
|    | 101|+TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
| 102| 102| 	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
| 103| 103| })();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 0 tabs but found 1.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/tests/test_Promotion.js
|  99|  99| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 30);
| 100| 100| 	cmpTimer.OnUpdate({ "turnLength": 8 });
| 101| 101| 	TS_ASSERT_EQUALS(cmpPromotion.GetCurrentXp(), 10);
| 102|    |-	TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
|    | 102|+TS_ASSERT_EQUALS(cmpPromotion.entity, 61);
| 103| 103| })();
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1912/display/redirect

Freagarach updated this revision to Diff 11557.Mar 26 2020, 9:08 AM

Please linter.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1913/display/redirect

Freagarach retitled this revision from Add simple test for XP trickle (rP23541). to Add simple test for XP trickle..Sat, May 9, 8:17 AM
Freagarach edited the summary of this revision. (Show Details)
bb added a subscriber: bb.Tue, May 12, 7:49 PM
bb added inline comments.
binaries/data/mods/public/simulation/components/tests/test_Promotion.js
9

while overhauling the entire file anyhow, make this entity as in most other tests

51–56

Appears we create functions to call them just once, why create them?

Freagarach added inline comments.Wed, May 13, 5:02 PM
binaries/data/mods/public/simulation/components/tests/test_Promotion.js
51–56

Because it easily identifies what is tested.

Freagarach updated this revision to Diff 11846.Wed, May 13, 5:06 PM

ENT_ID -> entity

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2105/display/redirect

Freagarach updated this revision to Diff 11847.Wed, May 13, 5:21 PM

Remove functions.

Freagarach marked an inline comment as done.Wed, May 13, 5:21 PM
Freagarach marked an inline comment as done.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2106/display/redirect

Freagarach updated this revision to Diff 11848.Wed, May 13, 5:49 PM

Test valuemodifications.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2107/display/redirect

bb accepted this revision as: bb.Thu, May 14, 5:06 PM
bb removed a reviewer: Restricted Owners Package.
bb added inline comments.
binaries/data/mods/public/simulation/components/tests/test_Promotion.js
21

trailing ,

130

useless, I see why you set it but, let someone who adds more tests do it

This revision is now accepted and ready to land.Thu, May 14, 5:06 PM

Thanks for the review and commit @bb!