Page MenuHomeWildfire Games

[art/actors] move siege tower and ram actors from structures to units
Needs ReviewPublic

Authored by Nescio on Mar 26 2020, 4:03 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Currently artillery actors and Roman rams are located under art/actors/units/*/, but siege towers and other rams are located under art/actors/structures/*/, which is not only inconsistent, but also quite confusing.
This patch:

  • Moves the siege tower and ram actors to the units folder and updates all affected templates accordingly.
  • While at it, also corrects the Greek specific names.
  • Introduces a separate actor for the Kushite siege tower (the only difference is the garrison flag).
  • Deletes the art/actors/structures/thebans/ folder, as it contains just one unused file, which is a duplicate of fireraiser already present in the units folder.
Test Plan

Check for mistakes, verify everything still works, agree this is an improvement.

Event Timeline

Nescio created this revision.Mar 26 2020, 4:03 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Mar 26 2020, 4:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1915/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1391/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/487/display/redirect

Stan added a comment.Mar 26 2020, 5:35 PM

Technically isn't a siege tower a "structure"?

Technically isn't a siege tower a "structure"?

It is an object constructed from several parts, so yes, that means it qualifies as structure, and it has a roof and walls, so it qualifies as a building too.
However, in 0 A.D. all siege entities are considered to be units (inherit from template_unit.xml, have the “Unit” class, and can move), not structures (inherit from template_structures.xml, have the “Structure” class, and can't move).
Moreover, having most siege actors in the units folder (e.g. Roman ram) but some in the structures folder (e.g. Persian ram) is both inconsistent and confusing.

Nescio retitled this revision from move siege tower and ram actors from structures to units to [art/actors] move siege tower and ram actors from structures to units.May 18 2020, 10:17 AM