Differential D2673

[art/actors] separate actor files for deprecated ptol structures
Needs ReviewPublic
Actions

Authored by Nescio on Mar 26 2020, 4:29 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

(Split from D2633.)
Some Ptolemaic structures (houses, towers, walls) have been replaced, however, the old meshes are still present in the files, hidden as frequency="0" variants, which is rather pointless. This patch creates separate actor files for those, so that they can show up in Atlas and be used by templates in mods, if desired.
Unnecessary variant lines are removed, frequencies are set to 1, names updated.

Test Plan

Agree this is an improvement.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 11332
Build 20485: Vulcan Build	Jenkins
Build 20484: Vulcan Build (macOS)	Jenkins
Build 20483: Vulcan Build (Windows)	Jenkins
Build 20482: arc lint + arc unit

Event Timeline

Nescio created this revision.Mar 26 2020, 4:29 PM

Owners added a subscriber: Restricted Owners Package.Mar 26 2020, 4:29 PM

Nescio added inline comments.Mar 26 2020, 4:30 PM

binaries/data/mods/public/art/actors/structures/ptolemies/temple.xml
14–24	See art/actors/structures/kushites/temple.xml.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1916/display/redirect

Harbormaster completed remote builds in B11332: Diff 11560.Mar 26 2020, 6:10 PM

cf. rP22977

Nescio retitled this revision from separate actor files for deprecated ptol structures to [art/actors] separate actor files for deprecated ptol structures.May 18 2020, 10:17 AM