Page MenuHomeWildfire Games

structure selection groups
ClosedPublic

Authored by Nescio on Mar 26 2020, 5:58 PM.

Details

Reviewers
ValihrAnt
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23580: [gameplay-a24] Structure selection groups
Summary

This patch sets selection groups for all shared structures in the generic parent templates of structures (as is already done for catafalques).
Clicking behaviour in 0 A.D. is as follows (unchanged):

  • single click: select the entity in question
  • double click: select all entities of the same selection group within view that are owned by this player (e.g. grouping b/a/e versions of the same unit)
  • triple click: select all entities of exactly the same file within view that are owned by this player (i.e. the same civ, rank, structure it is trained at, wall length, etc.)

Without this patch this means that if you've built e.g. farm fields of your own and captured some built by other civs, double (or triple) clicking on one will select only those that were built by the same civ, even though they're basically all equivalent.
With this patch double clicking will select all your fields within view, regardless who originally built them (and triple clicking will select only those of the same civ). The same applies to centres, houses, etc.
This will probably make playing 0 A.D. somewhat more convenient for both new and competitive players.
See also D2677 and D2681.

Test Plan

Check for mistakes and omissions. Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Mar 26 2020, 5:58 PM
Owners added a subscriber: Restricted Owners Package.Mar 26 2020, 5:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1918/display/redirect

ValihrAnt accepted this revision.Mar 26 2020, 8:19 PM
ValihrAnt added a subscriber: ValihrAnt.

This is a great improvement. When I'm trying to select all my barracks or Civic Centers I don't care from whom I captured something, I care about getting those buildings in the same selection.

This revision is now accepted and ready to land.Mar 26 2020, 8:19 PM
Nescio edited the summary of this revision. (Show Details)Mar 27 2020, 4:18 PM
Nescio edited the test plan for this revision. (Show Details)
Angen added a subscriber: Angen.Apr 6 2020, 6:55 PM

what about rome_siege_wall ? Is it supposed to be in the same selection group as stone wall ?

Nescio added a comment.Apr 6 2020, 8:31 PM

Currently siege walls have their own selection group (<SelectionGroupName>structures/rome_wallset_siege</SelectionGroupName>); this patch does not change that.

Angen added a comment.Apr 6 2020, 9:04 PM

yeah, correct, was looking to gate tower file

Does something need to be changed?

Angen added a comment.Apr 7 2020, 11:31 AM

nothing that I found and is used in game

This revision was automatically updated to reflect the committed changes.