Page MenuHomeWildfire Games

Move common functionality of Foundation and Repairable to Buildable.
AbandonedPublic

Authored by Freagarach on Mar 26 2020, 6:01 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

The idea is that the UnitAI should just query the new IID_Buildable to add a builder.

Test Plan

Verify that builders are able to build and repair.

Unit TestsFailed

TimeTest
0 msJenkins > TestComponentScripts::test_scripts
Assertion failed: componentManager->LoadScript(VfsPath(L"simulation/components") / pathname) Test failed: L"Running script simulation/components/tests/test_Foundation.js" Assertion failed: scriptInterface.LoadScript(pathname, content)
0 msJenkins > cxxtest-debug-gcc6.xml::[failed-to-read]
Failed to read test report file /zpool0/trunk/cxxtest-debug-gcc6.xml org.dom4j.DocumentException: Error on line 1 of document : Content is not allowed in prolog. at org.dom4j.io.SAXReader.read(SAXReader.java:462)
0 msJenkins > cxxtest-debug.xml::[failed-to-read]
Failed to read test report file /Users/wfg/Jenkins/workspace/macos-differential/cxxtest-debug.xml org.dom4j.DocumentException: Error on line 1 of document : Content is not allowed in prolog. at org.dom4j.io.SAXReader.read(SAXReader.java:462)
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAtlasObjectXML::test_parse_attributes1
View Full Test Results (3 Failed · 339 Passed)

Event Timeline

Freagarach created this revision.Mar 26 2020, 6:01 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1395/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1919/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/491/display/redirect

I'm not sure how (and if) this inheritance is properly used in the test.
Help is appreciated!

(I still think constructing a building should not necessarily be tied to Health.)

I think this only works because the naming is alphabetical, sadly :/

I'm not certain you actually need to inherit anything though. Can't this be entirely done without it?

You mean adding the Buildable component and querying that?

You mean adding the Buildable component and querying that?

Yes. I'm not sure it's a good idea or not.

Freagarach planned changes to this revision.Jun 6 2020, 9:36 AM

Something different ^^

Freagarach abandoned this revision.Thu, Jun 23, 4:13 PM