This will allow filters to remove tokens without the warning (needed for waning free D2674)
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 11337 Build 20504: Vulcan Build Jenkins Build 20503: Vulcan Build (macOS) Jenkins Build 20502: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/system/ParamNode.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2017" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1921/display/redirect
Comment Actions
This is bad. The warning is there for a reason: it is meaningful and helpful. It should be kept, not removed. Instead, find a way to make an exception for foundations.
Comment Actions
The only other option I see would be to introduce a new token that can be removed without a warning, The commit that introduced the warning fixed a crash when removing the token anyhow.