Page MenuHomeWildfire Games

[simulation2] remove warning in removing token in xml via filter
AbandonedPublic

Authored by nephele on Mar 26 2020, 6:52 PM.

Details

Reviewers
Nescio
Summary

This will allow filters to remove tokens without the warning (needed for waning free D2674)

Test Plan

I played with this

Event Timeline

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/system/ParamNode.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1921/display/redirect

Nescio requested changes to this revision.Mar 26 2020, 7:27 PM
Nescio added a subscriber: Nescio.

This is bad. The warning is there for a reason: it is meaningful and helpful. It should be kept, not removed. Instead, find a way to make an exception for foundations.

This revision now requires changes to proceed.Mar 26 2020, 7:27 PM

The only other option I see would be to introduce a new token that can be removed without a warning, The commit that introduced the warning fixed a crash when removing the token anyhow.

nephele abandoned this revision.Mar 26 2020, 8:23 PM

Not needed with the differing aproach in D2674.