This patch sets a selection group in the shared template_unit_hero.xml, which means that double-clicking on a hero will select all your heroes within view (as is already the case for catafalques). This does not really matter for ordinary random maps, where players can have at most one hero at any given time, but can be helpful for maps that start with multiple heroes, e.g. civilization sandbox scenarios.
See also D2675 and D2677.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Agree this is desirable.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 11350 Build 20546: Vulcan Build Jenkins Build 20545: Vulcan Build (macOS) Jenkins Build 20544: Vulcan Build (Windows) Jenkins Build 20543: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1930/display/redirect
Comment Actions
I disagree this is desirable, since heroes can be totally different units (they can be inf, cav, ele, healers etc.) and thus shouldn't be grouped as being only 1 kind in the formation tab. Do notice that heroes with the same template already are grouped (as it should). IMO the current behavior is correct.
The problem you are trying to solve: "select units with a certain class", should be solved differently, involving the classes, instead of setting an arbitrary key in the template.