Page MenuHomeWildfire Games

[gameplay] enable pers champion chariot
ClosedPublic

Authored by Nescio on Mar 27 2020, 12:32 PM.

Details

Reviewers
borg-
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23887: Train champion chariots at the Persian fortress.
Summary

A Persian champion chariot exists but is currently untrainable. This patch enables it and allows it to be recruited at maur, pers, and sele fortresses.

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Mar 27 2020, 12:32 PM
Owners added a subscriber: Restricted Owners Package.Mar 27 2020, 12:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1932/display/redirect

borg- requested changes to this revision.EditedJun 6 2020, 3:35 PM
borg- added a subscriber: borg-.

The patch seem not work. For work you need to add "units/{civ}_chariot", remove "champion".
Chariot is a parent of the heavy batric archer.
I would prefer to add the archer horseman, it works better with the current pathfinder and is also included in the design document. However needs a new icon, he uses the icon of the cavalry spearman champ.

This revision now requires changes to proceed.Jun 6 2020, 3:35 PM
Nescio added a comment.Jun 6 2020, 8:29 PM

It works on my end. pers_chariot.xml exist but is untrainable, due to its non-standard name; by moving (i.e. renaming) it to pers_champion_chariot.xml it becomes available (cf. brit, maur, sele).

borg- accepted this revision.Jun 12 2020, 1:00 PM
This revision is now accepted and ready to land.Jun 12 2020, 1:00 PM
Stan added a subscriber: Stan.Jun 19 2020, 8:35 AM

Can you rebase this? It seems the pers_fortress no longer has a production queue

<?xml version="1.0" encoding="utf-8"?>
<Entity parent="template_structure_military_fortress">
  <Identity>
    <Civ>pers</Civ>
    <SpecificName>Didā</SpecificName>
    <Tooltip>Research technologies. Garrison Soldiers for additional arrows.</Tooltip>
  </Identity>
  <VisualActor>
    <Actor>structures/persians/fortress.xml</Actor>
  </VisualActor>
  <WallPiece>
    <Length>24.5</Length>
    <Indent>7.6</Indent>
  </WallPiece>
</Entity>
Nescio updated this revision to Diff 12388.Jun 19 2020, 11:19 AM

Is there a point to the champion Chariot?

You mean historically? Yes, the use of scythed chariots by the Persians is well attested.
The first known occassion is the Battle of Cunaxa in 401 BC, described by Xenophon, who was an eye-witness. Cyrus the Younger had 20 (Xenophon Anabasis 1.7.10), Artaxerxes II 200 (1.7.11), of which 150 were present (1.7.12). How they looked is described in 1.8.10, their (negligible) effect vs Greeks is in 1.8.20.
At the Battle of Gaugamela in 331 BC, Darius III fielded 200 scythed chariots (Arrian Anabasis 3.11.6-7).

You mean historically?

I actually meant from a gameplay perspective ;)

I'm not against adding them if they're historically accurate, but if their gameplay role is basically 'be a fancy resource sink' it might not be that useful in regular play and so would be an argument to keep it only for scenarios.

Actually the Persian chariot is not used in any maps.
Mauryas and Seleucids have champion chariots too, but those are trainable, as is the Briton chariot javelineer. As for cost vs benefit, see D2816, but that's beyond the scope of this patch. Ideally I'd like to see Carthage and Kush get chariots too, but those require new actors.
A more interesting question is where chariots ought to be trainable, fortress, stable, or workshop.

Actually the Persian chariot is not used in any maps.
Mauryas and Seleucids have champion chariots too, but those are trainable, as is the Briton chariot javelineer. As for cost vs benefit, see D2816, but that's beyond the scope of this patch. Ideally I'd like to see Carthage and Kush get chariots too, but those require new actors.
A more interesting question is where chariots ought to be trainable, fortress, stable, or workshop.

I would put it were chariots were made so it means workshop with some techs there and stables but I guess from gameplay perspective it might be somewhere else.

borg- added a comment.Jul 14 2020, 1:38 PM

A more interesting question is where chariots ought to be trainable, fortress, stable, or workshop.

Workshop can be a good idea. I think chariots must be different than similar units. Maybe more hp/pierce armour but cost pop 2.

Yes, I'd like to see chariot templates be properly differentiated from cavalry; double health, population, resource costs would be a good start; something for a future patch.

wraitii accepted this revision.Jul 23 2020, 11:17 AM

Will commit tomorrow.

wraitii updated this revision to Diff 12900.Jul 25 2020, 9:24 AM

Update the fortress tooltip as well.

Persian fortress is rather lacklustre compared to other civs.

This revision was landed with ongoing or failed builds.Jul 25 2020, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2775/display/redirect