Page MenuHomeWildfire Games

Only store a "Garrison"-tag in map when there is actually Garrison to store.

Authored by Freagarach on Apr 3 2020, 8:10 PM.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
rP23634: Do not store empty Garrison tag in map xml files after rP23529
Test Plan

Verify that:

  • Maps without garrisoned units do not show unnecessary and empty Garrison-tags for GarrisonHolders.
  • Maps *with* garrisoned units *do* show (a filled) Garrison-tag.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Apr 3 2020, 8:10 PM
Owners added a subscriber: Restricted Owners Package.Apr 3 2020, 8:11 PM
Vulcan added a comment.Apr 3 2020, 8:33 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Silier accepted this revision.Apr 26 2020, 3:00 PM
Silier added a subscriber: Silier.

tag is optional and make sense to not store empty tag in files

This revision is now accepted and ready to land.Apr 26 2020, 3:00 PM
elexis edited the summary of this revision. (Show Details)Apr 26 2020, 3:38 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the commit and review @Angen :)