Page MenuHomeWildfire Games

Fixes FXAA on some platforms
ClosedPublic

Authored by vladislavbelov on Apr 12 2020, 8:43 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23606: Fixes FXAA on some platforms with broken GL drivers.
Summary

Some platforms deprecated and removed texture2DLod earlier than they should by OpenGL standard. Fixes FXAA after rP23484.

It needs to be tested on NVidia, AMD and Intel cards for Windows and Linux platforms.

Test Plan
  1. Apply the patch (no need to recompile the game)
  2. Enable FXAA
  3. Test that it works

Event Timeline

vladislavbelov created this revision.Apr 12 2020, 8:43 PM
vladislavbelov edited the summary of this revision. (Show Details)
vladislavbelov edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1995/display/redirect

Patch is working on my AMD Radeon RX 570 Manjaro Linux and Windows system.

Imarok added a subscriber: Imarok.Apr 13 2020, 12:51 PM

Works on Nvidia GTX 960 with Ubuntu 18.04

Works on Intel UHD 620 with Windows.

@vladislavbelov I chose fxaa, the sawtooth is still serious, and I tested the latest svn23587

There is a problem with fxaa. My chosen faction is Macedonia, and the map I used is: Seaside (2)

Imarok added a comment.EditedApr 19 2020, 1:27 PM

Works on Nvidia GTX 960 with Ubuntu 18.04

Same for GTX 960 with Windows 10

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 2:05 AM
This revision was automatically updated to reflect the committed changes.