Having a mouse event and a hotkey for the same hardware key turned out to be bad. If the mouse is above a gui element that handles the middle mouse event and the middle mouse is released, this event will be consumed by the gui handler of this gui element. Therefore the hotkey handler does not know that the key was released. If we change that behaviour typing in input fields would trigger hotkeys. So this seems unsolvable without adding special handling for the middle mouse case, which would be ugly.
Details
Details
- Reviewers
- None
- Commits
- rP23589: Revert rP23505 / r23505
- Trac Tickets
- #5695
Issue of trac ticket should be resolved.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
source/gui/CGUI.h
| 51| class·CGUI
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'classCGUI{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1997/display/redirect