Page MenuHomeWildfire Games

Fixes FXAA for maps with default effects

Authored by vladislavbelov on Apr 27 2020, 2:27 AM.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
rP23617: Fixes FXAA for maps with default effects, FXAA was introduced in rP23484.

FXAA was introduced in rP23484, and the problem is that FXAA wasn't available on maps with default effects. The patch fixes that.

Test Plan
  1. Apply the patch and compile the game
  2. Run the game on maps with default and non-default effects with FXAA on and off and Post-Processing on and off
  3. Make sure that it works as expected

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Apr 27 2020, 2:27 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

OptimusShepard accepted this revision.Apr 27 2020, 10:00 AM

Patch is working as expected. All tests passed as it should. Code looks correct.
Accepted. Thank you Vladislav

This revision is now accepted and ready to land.Apr 27 2020, 10:00 AM
Stan added a subscriber: Stan.Apr 27 2020, 11:06 PM

It works for me as well. I have no longer what @gameboy calls the sawtooth effect.

Stan requested changes to this revision.Apr 27 2020, 11:23 PM

This breaks the fixed render path.

This revision now requires changes to proceed.Apr 27 2020, 11:23 PM

Have you fixed it, my friend?

I tested this patch and it solved the problem, great! This person's patch is ready for formal submission.

Stan accepted this revision.Apr 30 2020, 8:36 AM

It was because I had


and that is broken both with and without the patch.

This revision is now accepted and ready to land.Apr 30 2020, 8:36 AM