FXAA was introduced in rP23484, and the problem is that FXAA wasn't available on maps with default effects. The patch fixes that.
Details
Details
- Reviewers
OptimusShepard Stan - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23617: Fixes FXAA for maps with default effects, FXAA was introduced in rP23484.
- Apply the patch and compile the game
- Run the game on maps with default and non-default effects with FXAA on and off and Post-Processing on and off
- Make sure that it works as expected
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2032/display/redirect
Comment Actions
Patch is working as expected. All tests passed as it should. Code looks correct.
Accepted. Thank you Vladislav
Comment Actions
@Stan
I tested this patch and it solved the problem, great! This person's patch is ready for formal submission.
Comment Actions
It was because I had
gpuskinning="true"
and that is broken both with and without the patch.