Page MenuHomeWildfire Games

update information in {civ}.json files
Needs ReviewPublic

Authored by Nescio on May 3 2020, 12:07 PM.

Details

Reviewers
ValihrAnt
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Currently, the Civilization Overview pages (i.e. {civ}.json files) are filled with false information. A lot of the mentioned features aren't part of the game and some mentioned bonuses are plain wrong. Moreover, information on many things that are specific to civilizations in 0 A.D. is absent.

This patch corrects and updates all the {civ}.json files:

  • Non-existent technologies, civ bonuses, and structures entries are removed.
  • Incorrect technologies, civ bonuses, and structures entries are updated.
  • Missing technologies, civ bonuses, and structures entries are removed.
  • Structures use the generic name (i.e. common English name) rather than the specific name (i.e. ancient language) for the Name fields.
  • The "Armament", "Class", "Emblem", "Phase", and "Requirements" fields of individual entries are purged, since they are not used, and unlikely to be displayed.
  • The "Special" field of structure entries is renamed to "Description", like the other entries, so it's actually displayed in game.

Initial patch by @ValihrAnt, rebased, updated, expanded, and redone by @Nescio.

Test Plan

Check for completeness and correctness.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Nescio added inline comments.Jun 15 2020, 12:05 PM
binaries/data/mods/public/simulation/data/civs/gaul.json
51–53

See above (brit.json).

binaries/data/mods/public/simulation/data/civs/iber.json
68

Remove the 'Revered Monument' part from this string.

binaries/data/mods/public/simulation/data/civs/kush.json
95

While at it, remove emblem.png.

102

Split entry into two (Small/Town and Large/City)

104

Also here.

106

And remove the ..

binaries/data/mods/public/simulation/data/civs/maur.json
23

Doesn't it apply to all archers?

72

Remove SB1.

81

Remove SB2.

binaries/data/mods/public/simulation/data/civs/pers.json
37

.

109

What is this?

126–127

Don't insert empty white lines.

binaries/data/mods/public/simulation/data/civs/ptol.json
57

free → don't cost resources
take longer to build → have a longer build time
and are weaker → and less health

75

.

binaries/data/mods/public/simulation/data/civs/rome.json
57

"Roman Siege Engines inflict more damage and have a longer range."

59

Don't insert unnecessary white lines.

This revision now requires changes to proceed.Jun 15 2020, 12:05 PM

Sorry, I clearly made the changes quite hurriedly and didn't carefully double-check for mistakes wasting your time. I also added some inline comments for the things I'm unsure about.

binaries/data/mods/public/simulation/data/civs/brit.json
51

None that I could think of then. "Living Spaces" is one I just thought of. Don't know if it's any better.

53

How should I better word it? "Briton structures, except fortifications, Siege Workshops, and Kennels, provide an additional Population bonus" wouldn't be correct as forts give a population bonus and two exceptions in one sentence probably aren't good. Alternatively listing all the buildings which give a population bonus would be quite long.

binaries/data/mods/public/simulation/data/civs/maur.json
23

It is only available to Persians, Mauryans and Kushites.

ValihrAnt added inline comments.Jun 15 2020, 12:45 PM
binaries/data/mods/public/simulation/data/civs/pers.json
109

It's the generic name of the Ishtar Gate of Babylon. I guess it would be better then to make an exception and use the specific name?

Sorry, I clearly made the changes quite hurriedly and didn't carefully double-check for mistakes wasting your time. I also added some inline comments for the things I'm unsure about.

There is no need to apologize, I often miss things too, and spot other points whenever a new version is uploaded. It's all part of the review process. It would be unnatural if a large patch such as this was perfect on the first instance. We'll probably go back and forth a few more times, until we're both satisfied it's complete, consistent, and correct.

  • Also replace "emblem.png" with "" in the kush.json file (under structures and heroes).
binaries/data/mods/public/simulation/data/civs/brit.json
53

How about "Most Briton Structures ..."?
To do: check if that's true. It may turn out they're actually a minority.

binaries/data/mods/public/simulation/data/civs/maur.json
23

No, I mean the technology has "Archer", not "Infantry Archer".

ValihrAnt updated this revision to Diff 12324.Jun 15 2020, 2:26 PM

Removed "."
Adjusted wording for Gaul, Briton, Roman, and Ptolemy bonuses. About half of the Celtic buildings provide a population bonus, if not counting the house, CCs, Wonder and Fort so I used "Some" instead of "Most"
Removed incorrect history from Rotary Mill, removed unnecessary text from Revered Monument.
Split Kushite pyramids
Adjusted "Archery Tradition" to reflect that it affects all archers not just infantry.

ValihrAnt updated this revision to Diff 12325.Jun 15 2020, 2:30 PM
ValihrAnt marked 22 inline comments as done.

Fix an unnecessary space.

borg- added a subscriber: borg-.Jun 15 2020, 3:47 PM

Very good patch.

Nescio requested changes to this revision.Jun 15 2020, 4:21 PM
Nescio removed a reviewer: asterix.
  • There are several other civ bonuses hidden in the templates files (cart_ship_merchant.xml, iber_defense_tower.xml, iber_fortress.xml, pers_siege_ram.xml, etc.). I don't know if you want to include them in this patch too, as you did with celt structures and rome siege, or insert those in a future patch?
  • cart.json: list Iberian embassy before Italic embassy, to reflect actual build order (see structure tree); also, Italian → Italic (D2796).
  • kush.json: list pyramids before Grand Temple of Amun, to reflect availability; also, "emblem.png""" in lines 37, 44, 51.
  • Not all structure descriptions (the "Special": strings) are exactly accurate (e.g. lighthouse). Where applicable, you might want to take the strings from the template tooltips proposed in D2578.
binaries/data/mods/public/simulation/data/civs/iber.json
71

Build limit.

binaries/data/mods/public/simulation/data/civs/maur.json
76

Purge, incorrect.

77

It seems unimportant, condense to "Train Elephants.", or purge?

84

Purge, incorrect.

binaries/data/mods/public/simulation/data/civs/pers.json
85

Actually it's +25%, see pers_support_trader.xml.

91

"Stable"

97

"Train Cavalry."
Or purge.

109

That specific name ought to be the generic name, so yes.

binaries/data/mods/public/simulation/data/civs/ptol.json
57

Oxford comma (, and ) when more than two items, per style guide.

86

Build limit.

95

Build limit.

binaries/data/mods/public/simulation/data/civs/rome.json
55

How about "Legionary Engineers"?

binaries/data/mods/public/simulation/data/civs/sele.json
76

Build limit.

This revision now requires changes to proceed.Jun 15 2020, 4:21 PM
Nescio retitled this revision from remove misinformation from {civ}.json files to update information in {civ}.json files.Jun 15 2020, 4:23 PM

The "Special": strings of the structures actually don't show up in game:


If "Special": is replaced with "Description":, as other entries have, then it is displayed:

ValihrAnt updated this revision to Diff 12335.Jun 16 2020, 12:21 PM

Moved the listed order of some buildings to fit with the Structure Tree.
Removed build limits from the Special strings.
Added bonuses that were hidden in template files. I struggled in thinking up names and descriptions, so plenty of room for improvement there I think, especially for the Iberians.
Changed "Special" for the Lighthouse, removed it from the Library.

Added bonuses that were hidden in template files.

To be clear, those I listed earlier were the once I remembered; I didn't check all templates, so there are probably a few more.
Also, what's your opinion on "Special":"Description": (to display the structure strings in the civilization overview)?

To be clear, those I listed earlier were the once I remembered; I didn't check all templates, so there are probably a few more.

I guess if more are found they can be added later.

Also, what's your opinion on "Special": → "Description": (to display the structure strings in the civilization overview)?

Wouldn't screen constraints be a problem? With this patch, the Persian Special Technologies alone go almost to the very bottom of the tab. Though in general, I think it would be best to display a description of what the building does because just the name of the unique building may not convey its purpose.

Nescio updated this revision to Diff 12343.Jun 16 2020, 11:29 PM
  • Included civ bonuses located in the technologies folder.
  • Included missing civ specific technologies.
  • Included aura descriptions for library and theater.
  • Condensed and rephrased multiple strings.
  • Some other minor corrections.

Wouldn't screen constraints be a problem? With this patch, the Persian Special Technologies alone go almost to the very bottom of the tab. Though in general, I think it would be best to display a description of what the building does because just the name of the unique building may not convey its purpose.

Yeah, the Persians have a lot of technologies. I just checked, displaying structure descriptions fits, but barely, so there is no room for future additions. The other civs have plenty of space. You can include the "Special": → "Description": in this patch if you like, or leave it for a separate differential. I mentioned it because sometimes one spots different mistakes when viewing strings in game.

Also, I noticed many of the civ bonuses located in the technologies folder was missing. Because it was faster to do it myself than to request changes in this case, I took the liberty to include them and several other things and update your patch.
However, more work has still to be done. I'll continue the review later.

Nescio added inline comments.Jun 18 2020, 9:35 PM
binaries/data/mods/public/simulation/data/civs/cart.json
26

Remove unnecessary white line.
Also applies to other files.

62

How about?

  • Commercial Acumen
  • Experienced Merchants
  • Maritime Republic
  • Mercantile Empire
  • Phoenician Tradition
  • Punic Products
  • Trademasters
binaries/data/mods/public/simulation/data/civs/iber.json
75

Replace with: "Nearby Soldiers +20% attack damage."

Nescio requested changes to this revision.Jun 19 2020, 10:09 AM
Nescio added inline comments.
binaries/data/mods/public/simulation/data/civs/brit.json
63–70

Remove kennel, since it's deprecated by D2533/rP23781.

This revision now requires changes to proceed.Jun 19 2020, 10:09 AM
ValihrAnt updated this revision to Diff 12393.Jun 19 2020, 7:05 PM

Removed kennel.
Changed Carthaginian trade bonus name to "Commercial Acumen".

Nescio requested changes to this revision.Jun 19 2020, 8:00 PM

Something I didn't notice in earlier versions: your patch replaces eight occurrences of the proper minus sign (−) with an hyphen-minus (-). Please don't: minus signs are there for a reason, see style guide, replacing them is a regression.
Furthermore, the Heroes part of the iber.json, rome.json, and sele.json files seem messed up.
Also:

No newline at end of file

Maybe your text editor is messing up things?

It's probably less work to base yourself off the previous diff (12343) than it is to correct the latest diff (12393).

binaries/data/mods/public/simulation/data/civs/brit.json
27

What changed here? Please revert. Even the change of a single space would force the entire string to be retranslated in all languages.

binaries/data/mods/public/simulation/data/civs/gaul.json
34

Whatever changed here, please revert. See earlier comment.

This revision now requires changes to proceed.Jun 19 2020, 8:00 PM
Stan added inline comments.Jun 19 2020, 8:05 PM
binaries/data/mods/public/simulation/data/civs/brit.json
27

speech…"

binaries/data/mods/public/simulation/data/civs/gaul.json
34

“History of the Kings of Britain”

Nescio added inline comments.Jun 19 2020, 8:16 PM
binaries/data/mods/public/simulation/data/civs/brit.json
27

https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/data/civs/brit.json#L39
Nor did this happen in any of the nine earlier versions @ValihrAnt uploaded (11789, 11791, 11797, 11799, 12322, 12324, 12325, 12335).
I suspect somehow the encoding was changed.

binaries/data/mods/public/simulation/data/civs/gaul.json
34
Nescio commandeered this revision.Jul 17 2020, 3:08 PM
Nescio edited reviewers, added: ValihrAnt; removed: Nescio.
This revision now requires review to proceed.Jul 17 2020, 3:08 PM
Nescio planned changes to this revision.Jul 17 2020, 3:08 PM
Nescio updated this revision to Diff 12969.Jul 30 2020, 10:27 PM
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
Nescio added a reviewer: Restricted Owners Package.
  • redone from scratch
Owners added a subscriber: Restricted Owners Package.Jul 30 2020, 10:27 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2811/display/redirect

Nescio added a subscriber: Itms.Jul 30 2020, 10:35 PM

Owners added a subscriber: O11: Templates (Balancing).

@Itms, @Stan, the {civ}.json files don't actually affect gameplay balance.