Page MenuHomeWildfire Games

Enable preSelectedAction on the minimap
ClosedPublic

Authored by Imarok on May 9 2020, 8:25 PM.

Details

Summary

This patch enables the use of preSelectedActions (the one you use when pressing gui command buttons) on the minimap.
They should behave the same way as on the normal map. (Except that you can't apply actions on entities. (Like repairing))

Test Plan

Do some preselectedActions on the minimap.
When doing the action the minimap shouldn't move.
Test that queueing works.
Test that canceling works.
Test that it behaves the same as doing it on the normal map.
Also test the usual interaction with the minimap (moving the map, doing rightclick actions like patrolling).

Event Timeline

Imarok created this revision.May 9 2020, 8:25 PM
Imarok updated this revision to Diff 11823.May 9 2020, 8:31 PM

Don't upload changes from D2727

Vulcan added a comment.May 9 2020, 8:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1565/display/redirect

Vulcan added a comment.May 9 2020, 8:34 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/gui/ObjectTypes/CMiniMap.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/gui/ObjectTypes/CMiniMap.h
|  29| class·CMiniMap·:·public·IGUIObject
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMiniMap:' is invalid C code. Use --std or --language to configure the language.

source/gui/ObjectBases/IGUIObject.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/gui/ObjectBases/IGUIObject.h
|  53| class·IGUIObject
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classIGUIObject{' is invalid C code. Use --std or --language to configure the language.

source/gui/ObjectBases/IGUIObject.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/gui/ObjectTypes/CMiniMap.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'actionInfo' to undefined.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 238| 238| 	// if two actions are possible, the first one is taken
| 239| 239| 	// thus the most specific should appear first.
| 240| 240| 
| 241|    |-	let actionInfo = undefined;
|    | 241|+	let actionInfo;
| 242| 242| 	if (preSelectedAction != ACTION_NONE)
| 243| 243| 	{
| 244| 244| 		for (let action of g_UnitActionsSortedKeys)
|    | [NORMAL] ESLintBear (space-unary-ops):
|    | Unary word operator 'typeof' must be followed by whitespace.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 332| 332| 	}
| 333| 333| 
| 334| 334| 	var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...)
| 335|    |-	if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object"))
|    | 335|+	if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object"))
| 336| 336| 	{
| 337| 337| 		error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo));
| 338| 338| 		return false;
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 482| 482| 	mouseIsOverObject = (hoveredObject != null);
| 483| 483| 
| 484| 484| 	// Close the menu when interacting with the game world
| 485|    |-	if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown")
| 486|    |-		&& (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT))
|    | 485|+	if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") &&
|    | 486|+		(ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT))
| 487| 487| 		g_Menu.close();
| 488| 488| 
| 489| 489| 	// State-machine processing:
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 3.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 643| 643| 		// user to continue building walls.
| 644| 644| 		switch (ev.type)
| 645| 645| 		{
| 646|    |-			case "mousemotion":
|    | 646|+		case "mousemotion":
| 647| 647| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 648| 648| 
| 649| 649| 				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 644| 644| 		switch (ev.type)
| 645| 645| 		{
| 646| 646| 			case "mousemotion":
| 647|    |-				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
|    | 647|+			placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 648| 648| 
| 649| 649| 				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
| 650| 650| 				// the ending point and the starting point to snap to.
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 646| 646| 			case "mousemotion":
| 647| 647| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 648| 648| 
| 649|    |-				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
|    | 649|+			// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
| 650| 650| 				// the ending point and the starting point to snap to.
| 651| 651| 				//
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 647| 647| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 648| 648| 
| 649| 649| 				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
| 650|    |-				// the ending point and the starting point to snap to.
|    | 650|+			// the ending point and the starting point to snap to.
| 651| 651| 				//
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 648| 648| 
| 649| 649| 				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
| 650| 650| 				// the ending point and the starting point to snap to.
| 651|    |-				//
|    | 651|+			//
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 649| 649| 				// Update the structure placement preview, and by extension, the list of snapping candidate entities for both (!)
| 650| 650| 				// the ending point and the starting point to snap to.
| 651| 651| 				//
| 652|    |-				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
|    | 652|+			// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655| 655| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 650| 650| 				// the ending point and the starting point to snap to.
| 651| 651| 				//
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653|    |-				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
|    | 653|+			// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655| 655| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 656| 656| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 651| 651| 				//
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654|    |-				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
|    | 654|+			// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655| 655| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 656| 656| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 657| 657| 				// points.
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 652| 652| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655|    |-				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
|    | 655|+			// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 656| 656| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 657| 657| 				// points.
| 658| 658| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 653| 653| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655| 655| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 656|    |-				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
|    | 656|+			// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 657| 657| 				// points.
| 658| 658| 
| 659| 659| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 654| 654| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 655| 655| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 656| 656| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 657|    |-				// points.
|    | 657|+			// points.
| 658| 658| 
| 659| 659| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 660| 660| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 656| 656| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 657| 657| 				// points.
| 658| 658| 
| 659|    |-				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
|    | 659|+			placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 660| 660| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 661| 661| 
| 662| 662| 				if (result && result.cost)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 657| 657| 				// points.
| 658| 658| 
| 659| 659| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 660|    |-				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
|    | 660|+			var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 661| 661| 
| 662| 662| 				if (result && result.cost)
| 663| 663| 				{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 659| 659| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 660| 660| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 661| 661| 
| 662|    |-				if (result && result.cost)
|    | 662|+			if (result && result.cost)
| 663| 663| 				{
| 664| 664| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665| 665| 					placementSupport.tooltipMessage = [
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 660| 660| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 661| 661| 
| 662| 662| 				if (result && result.cost)
| 663|    |-				{
|    | 663|+			{
| 664| 664| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665| 665| 					placementSupport.tooltipMessage = [
| 666| 666| 						getEntityCostTooltip(result),
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 661| 661| 
| 662| 662| 				if (result && result.cost)
| 663| 663| 				{
| 664|    |-					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
|    | 664|+				var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665| 665| 					placementSupport.tooltipMessage = [
| 666| 666| 						getEntityCostTooltip(result),
| 667| 667| 						getNeededResourcesTooltip(neededResources)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 662| 662| 				if (result && result.cost)
| 663| 663| 				{
| 664| 664| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665|    |-					placementSupport.tooltipMessage = [
|    | 665|+				placementSupport.tooltipMessage = [
| 666| 666| 						getEntityCostTooltip(result),
| 667| 667| 						getNeededResourcesTooltip(neededResources)
| 668| 668| 					].filter(tip => tip).join("\n");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 663| 663| 				{
| 664| 664| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665| 665| 					placementSupport.tooltipMessage = [
| 666|    |-						getEntityCostTooltip(result),
|    | 666|+					getEntityCostTooltip(result),
| 667| 667| 						getNeededResourcesTooltip(neededResources)
| 668| 668| 					].filter(tip => tip).join("\n");
| 669| 669| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 664| 664| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 665| 665| 					placementSupport.tooltipMessage = [
| 666| 666| 						getEntityCostTooltip(result),
| 667|    |-						getNeededResourcesTooltip(neededResources)
|    | 667|+					getNeededResourcesTooltip(neededResources)
| 668| 668| 					].filter(tip => tip).join("\n");
| 669| 669| 				}
| 670| 670| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 665| 665| 					placementSupport.tooltipMessage = [
| 666| 666| 						getEntityCostTooltip(result),
| 667| 667| 						getNeededResourcesTooltip(neededResources)
| 668|    |-					].filter(tip => tip).join("\n");
|    | 668|+				].filter(tip => tip).join("\n");
| 669| 669| 				}
| 670| 670| 
| 671| 671| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 666| 666| 						getEntityCostTooltip(result),
| 667| 667| 						getNeededResourcesTooltip(neededResources)
| 668| 668| 					].filter(tip => tip).join("\n");
| 669|    |-				}
|    | 669|+			}
| 670| 670| 
| 671| 671| 				break;
| 672| 672| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 668| 668| 					].filter(tip => tip).join("\n");
| 669| 669| 				}
| 670| 670| 
| 671|    |-				break;
|    | 671|+			break;
| 672| 672| 
| 673| 673| 			case "mousebuttondown":
| 674| 674| 				if (ev.button == SDL_BUTTON_LEFT)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 3.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 670| 670| 
| 671| 671| 				break;
| 672| 672| 
| 673|    |-			case "mousebuttondown":
|    | 673|+		case "mousebuttondown":
| 674| 674| 				if (ev.button == SDL_BUTTON_LEFT)
| 675| 675| 				{
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 671| 671| 				break;
| 672| 672| 
| 673| 673| 			case "mousebuttondown":
| 674|    |-				if (ev.button == SDL_BUTTON_LEFT)
|    | 674|+			if (ev.button == SDL_BUTTON_LEFT)
| 675| 675| 				{
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 677| 677| 					if (tryPlaceWall(queued))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 672| 672| 
| 673| 673| 			case "mousebuttondown":
| 674| 674| 				if (ev.button == SDL_BUTTON_LEFT)
| 675|    |-				{
|    | 675|+			{
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 677| 677| 					if (tryPlaceWall(queued))
| 678| 678| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 673| 673| 			case "mousebuttondown":
| 674| 674| 				if (ev.button == SDL_BUTTON_LEFT)
| 675| 675| 				{
| 676|    |-					var queued = Engine.HotkeyIsPressed("session.queue");
|    | 676|+				var queued = Engine.HotkeyIsPressed("session.queue");
| 677| 677| 					if (tryPlaceWall(queued))
| 678| 678| 					{
| 679| 679| 						if (queued)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 674| 674| 				if (ev.button == SDL_BUTTON_LEFT)
| 675| 675| 				{
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 677|    |-					if (tryPlaceWall(queued))
|    | 677|+				if (tryPlaceWall(queued))
| 678| 678| 					{
| 679| 679| 						if (queued)
| 680| 680| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 675| 675| 				{
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 677| 677| 					if (tryPlaceWall(queued))
| 678|    |-					{
|    | 678|+				{
| 679| 679| 						if (queued)
| 680| 680| 						{
| 681| 681| 							// continue building, just set a new starting position where we left off
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 676| 676| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 677| 677| 					if (tryPlaceWall(queued))
| 678| 678| 					{
| 679|    |-						if (queued)
|    | 679|+					if (queued)
| 680| 680| 						{
| 681| 681| 							// continue building, just set a new starting position where we left off
| 682| 682| 							placementSupport.position = placementSupport.wallEndPosition;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 677| 677| 					if (tryPlaceWall(queued))
| 678| 678| 					{
| 679| 679| 						if (queued)
| 680|    |-						{
|    | 680|+					{
| 681| 681| 							// continue building, just set a new starting position where we left off
| 682| 682| 							placementSupport.position = placementSupport.wallEndPosition;
| 683| 683| 							placementSupport.wallEndPosition = undefined;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 678| 678| 					{
| 679| 679| 						if (queued)
| 680| 680| 						{
| 681|    |-							// continue building, just set a new starting position where we left off
|    | 681|+						// continue building, just set a new starting position where we left off
| 682| 682| 							placementSupport.position = placementSupport.wallEndPosition;
| 683| 683| 							placementSupport.wallEndPosition = undefined;
| 684| 684| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 679| 679| 						if (queued)
| 680| 680| 						{
| 681| 681| 							// continue building, just set a new starting position where we left off
| 682|    |-							placementSupport.position = placementSupport.wallEndPosition;
|    | 682|+						placementSupport.position = placementSupport.wallEndPosition;
| 683| 683| 							placementSupport.wallEndPosition = undefined;
| 684| 684| 
| 685| 685| 							inputState = INPUT_BUILDING_WALL_CLICK;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 680| 680| 						{
| 681| 681| 							// continue building, just set a new starting position where we left off
| 682| 682| 							placementSupport.position = placementSupport.wallEndPosition;
| 683|    |-							placementSupport.wallEndPosition = undefined;
|    | 683|+						placementSupport.wallEndPosition = undefined;
| 684| 684| 
| 685| 685| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 686| 686| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 682| 682| 							placementSupport.position = placementSupport.wallEndPosition;
| 683| 683| 							placementSupport.wallEndPosition = undefined;
| 684| 684| 
| 685|    |-							inputState = INPUT_BUILDING_WALL_CLICK;
|    | 685|+						inputState = INPUT_BUILDING_WALL_CLICK;
| 686| 686| 						}
| 687| 687| 						else
| 688| 688| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 683| 683| 							placementSupport.wallEndPosition = undefined;
| 684| 684| 
| 685| 685| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 686|    |-						}
|    | 686|+					}
| 687| 687| 						else
| 688| 688| 						{
| 689| 689| 							placementSupport.Reset();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 684| 684| 
| 685| 685| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 686| 686| 						}
| 687|    |-						else
|    | 687|+					else
| 688| 688| 						{
| 689| 689| 							placementSupport.Reset();
| 690| 690| 							inputState = INPUT_NORMAL;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 685| 685| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 686| 686| 						}
| 687| 687| 						else
| 688|    |-						{
|    | 688|+					{
| 689| 689| 							placementSupport.Reset();
| 690| 690| 							inputState = INPUT_NORMAL;
| 691| 691| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 686| 686| 						}
| 687| 687| 						else
| 688| 688| 						{
| 689|    |-							placementSupport.Reset();
|    | 689|+						placementSupport.Reset();
| 690| 690| 							inputState = INPUT_NORMAL;
| 691| 691| 						}
| 692| 692| 					}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 687| 687| 						else
| 688| 688| 						{
| 689| 689| 							placementSupport.Reset();
| 690|    |-							inputState = INPUT_NORMAL;
|    | 690|+						inputState = INPUT_NORMAL;
| 691| 691| 						}
| 692| 692| 					}
| 693| 693| 					else
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 688| 688| 						{
| 689| 689| 							placementSupport.Reset();
| 690| 690| 							inputState = INPUT_NORMAL;
| 691|    |-						}
|    | 691|+					}
| 692| 692| 					}
| 693| 693| 					else
| 694| 694| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 689| 689| 							placementSupport.Reset();
| 690| 690| 							inputState = INPUT_NORMAL;
| 691| 691| 						}
| 692|    |-					}
|    | 692|+				}
| 693| 693| 					else
| 694| 694| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 695| 695| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 690| 690| 							inputState = INPUT_NORMAL;
| 691| 691| 						}
| 692| 692| 					}
| 693|    |-					else
|    | 693|+				else
| 694| 694| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 695| 695| 
| 696| 696| 					updateBuildingPlacementPreview();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 691| 691| 						}
| 692| 692| 					}
| 693| 693| 					else
| 694|    |-						placementSupport.tooltipMessage = translate("Cannot build wall here!");
|    | 694|+					placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 695| 695| 
| 696| 696| 					updateBuildingPlacementPreview();
| 697| 697| 					return true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 693| 693| 					else
| 694| 694| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 695| 695| 
| 696|    |-					updateBuildingPlacementPreview();
|    | 696|+				updateBuildingPlacementPreview();
| 697| 697| 					return true;
| 698| 698| 				}
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 694| 694| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 695| 695| 
| 696| 696| 					updateBuildingPlacementPreview();
| 697|    |-					return true;
|    | 697|+				return true;
| 698| 698| 				}
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 700| 700| 				{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 695| 695| 
| 696| 696| 					updateBuildingPlacementPreview();
| 697| 697| 					return true;
| 698|    |-				}
|    | 698|+			}
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 700| 700| 				{
| 701| 701| 					// reset to normal input mode
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 696| 696| 					updateBuildingPlacementPreview();
| 697| 697| 					return true;
| 698| 698| 				}
| 699|    |-				else if (ev.button == SDL_BUTTON_RIGHT)
|    | 699|+			else if (ev.button == SDL_BUTTON_RIGHT)
| 700| 700| 				{
| 701| 701| 					// reset to normal input mode
| 702| 702| 					placementSupport.Reset();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 697| 697| 					return true;
| 698| 698| 				}
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 700|    |-				{
|    | 700|+			{
| 701| 701| 					// reset to normal input mode
| 702| 702| 					placementSupport.Reset();
| 703| 703| 					updateBuildingPlacementPreview();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 698| 698| 				}
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 700| 700| 				{
| 701|    |-					// reset to normal input mode
|    | 701|+				// reset to normal input mode
| 702| 702| 					placementSupport.Reset();
| 703| 703| 					updateBuildingPlacementPreview();
| 704| 704| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 699| 699| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 700| 700| 				{
| 701| 701| 					// reset to normal input mode
| 702|    |-					placementSupport.Reset();
|    | 702|+				placementSupport.Reset();
| 703| 703| 					updateBuildingPlacementPreview();
| 704| 704| 
| 705| 705| 					inputState = INPUT_NORMAL;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 700| 700| 				{
| 701| 701| 					// reset to normal input mode
| 702| 702| 					placementSupport.Reset();
| 703|    |-					updateBuildingPlacementPreview();
|    | 703|+				updateBuildingPlacementPreview();
| 704| 704| 
| 705| 705| 					inputState = INPUT_NORMAL;
| 706| 706| 					return true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 702| 702| 					placementSupport.Reset();
| 703| 703| 					updateBuildingPlacementPreview();
| 704| 704| 
| 705|    |-					inputState = INPUT_NORMAL;
|    | 705|+				inputState = INPUT_NORMAL;
| 706| 706| 					return true;
| 707| 707| 				}
| 708| 708| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 703| 703| 					updateBuildingPlacementPreview();
| 704| 704| 
| 705| 705| 					inputState = INPUT_NORMAL;
| 706|    |-					return true;
|    | 706|+				return true;
| 707| 707| 				}
| 708| 708| 				break;
| 709| 709| 		}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 704| 704| 
| 705| 705| 					inputState = INPUT_NORMAL;
| 706| 706| 					return true;
| 707|    |-				}
|    | 707|+			}
| 708| 708| 				break;
| 709| 709| 		}
| 710| 710| 		break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 705| 705| 					inputState = INPUT_NORMAL;
| 706| 706| 					return true;
| 707| 707| 				}
| 708|    |-				break;
|    | 708|+			break;
| 709| 709| 		}
| 710| 710| 		break;
| 711| 711| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 847| 847| 			break;
| 848| 848| 
| 849| 849| 		case "hotkeydown":
| 850|    |-				if (ev.hotkey.indexOf("selection.group.") == 0)
|    | 850|+			if (ev.hotkey.indexOf("selection.group.") == 0)
| 851| 851| 				{
| 852| 852| 					let now = Date.now();
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 848| 848| 
| 849| 849| 		case "hotkeydown":
| 850| 850| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 851|    |-				{
|    | 851|+			{
| 852| 852| 					let now = Date.now();
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854| 854| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 849| 849| 		case "hotkeydown":
| 850| 850| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 851| 851| 				{
| 852|    |-					let now = Date.now();
|    | 852|+				let now = Date.now();
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854| 854| 					{
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 850| 850| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 851| 851| 				{
| 852| 852| 					let now = Date.now();
| 853|    |-					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
|    | 853|+				if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854| 854| 					{
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856| 856| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 851| 851| 				{
| 852| 852| 					let now = Date.now();
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854|    |-					{
|    | 854|+				{
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856| 856| 						{
| 857| 857| 							var sptr = ev.hotkey.split(".");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 852| 852| 					let now = Date.now();
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854| 854| 					{
| 855|    |-						if (ev.hotkey.indexOf("selection.group.select.") == 0)
|    | 855|+					if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856| 856| 						{
| 857| 857| 							var sptr = ev.hotkey.split(".");
| 858| 858| 							performGroup("snap", sptr[3]);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 853| 853| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 854| 854| 					{
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856|    |-						{
|    | 856|+					{
| 857| 857| 							var sptr = ev.hotkey.split(".");
| 858| 858| 							performGroup("snap", sptr[3]);
| 859| 859| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 854| 854| 					{
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856| 856| 						{
| 857|    |-							var sptr = ev.hotkey.split(".");
|    | 857|+						var sptr = ev.hotkey.split(".");
| 858| 858| 							performGroup("snap", sptr[3]);
| 859| 859| 						}
| 860| 860| 					}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 855| 855| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 856| 856| 						{
| 857| 857| 							var sptr = ev.hotkey.split(".");
| 858|    |-							performGroup("snap", sptr[3]);
|    | 858|+						performGroup("snap", sptr[3]);
| 859| 859| 						}
| 860| 860| 					}
| 861| 861| 					else
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 856| 856| 						{
| 857| 857| 							var sptr = ev.hotkey.split(".");
| 858| 858| 							performGroup("snap", sptr[3]);
| 859|    |-						}
|    | 859|+					}
| 860| 860| 					}
| 861| 861| 					else
| 862| 862| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 857| 857| 							var sptr = ev.hotkey.split(".");
| 858| 858| 							performGroup("snap", sptr[3]);
| 859| 859| 						}
| 860|    |-					}
|    | 860|+				}
| 861| 861| 					else
| 862| 862| 					{
| 863| 863| 						var sptr = ev.hotkey.split(".");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 858| 858| 							performGroup("snap", sptr[3]);
| 859| 859| 						}
| 860| 860| 					}
| 861|    |-					else
|    | 861|+				else
| 862| 862| 					{
| 863| 863| 						var sptr = ev.hotkey.split(".");
| 864| 864| 						performGroup(sptr[2], sptr[3]);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 859| 859| 						}
| 860| 860| 					}
| 861| 861| 					else
| 862|    |-					{
|    | 862|+				{
| 863| 863| 						var sptr = ev.hotkey.split(".");
| 864| 864| 						performGroup(sptr[2], sptr[3]);
| 865| 865| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 860| 860| 					}
| 861| 861| 					else
| 862| 862| 					{
| 863|    |-						var sptr = ev.hotkey.split(".");
|    | 863|+					var sptr = ev.hotkey.split(".");
| 864| 864| 						performGroup(sptr[2], sptr[3]);
| 865| 865| 
| 866| 866| 						doublePressTimer = now;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 861| 861| 					else
| 862| 862| 					{
| 863| 863| 						var sptr = ev.hotkey.split(".");
| 864|    |-						performGroup(sptr[2], sptr[3]);
|    | 864|+					performGroup(sptr[2], sptr[3]);
| 865| 865| 
| 866| 866| 						doublePressTimer = now;
| 867| 867| 						prevHotkey = ev.hotkey;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 863| 863| 						var sptr = ev.hotkey.split(".");
| 864| 864| 						performGroup(sptr[2], sptr[3]);
| 865| 865| 
| 866|    |-						doublePressTimer = now;
|    | 866|+					doublePressTimer = now;
| 867| 867| 						prevHotkey = ev.hotkey;
| 868| 868| 					}
| 869| 869| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 864| 864| 						performGroup(sptr[2], sptr[3]);
| 865| 865| 
| 866| 866| 						doublePressTimer = now;
| 867|    |-						prevHotkey = ev.hotkey;
|    | 867|+					prevHotkey = ev.hotkey;
| 868| 868| 					}
| 869| 869| 				}
| 870| 870| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 865| 865| 
| 866| 866| 						doublePressTimer = now;
| 867| 867| 						prevHotkey = ev.hotkey;
| 868|    |-					}
|    | 868|+				}
| 869| 869| 				}
| 870| 870| 				break;
| 871| 871| 		}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 866| 866| 						doublePressTimer = now;
| 867| 867| 						prevHotkey = ev.hotkey;
| 868| 868| 					}
| 869|    |-				}
|    | 869|+			}
| 870| 870| 				break;
| 871| 871| 		}
| 872| 872| 		break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 867| 867| 						prevHotkey = ev.hotkey;
| 868| 868| 					}
| 869| 869| 				}
| 870|    |-				break;
|    | 870|+			break;
| 871| 871| 		}
| 872| 872| 		break;
| 873| 873| 
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|1599|1599| 	var selectall = Engine.HotkeyIsPressed("selection.offscreen");
|1600|1600| 
|1601|1601| 	// Reset the last idle unit, etc., if the selection type has changed.
|1602|    |-	if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i]))
|    |1602|+	if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i]))
|1603|1603| 		resetIdleUnit();
|1604|1604| 	lastIdleClasses = classes;
|1605|1605| 

binaries/data/mods/public/gui/session/input.js
| 471| »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 498| »   switch·(inputState)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 502| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 557| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 567| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 615| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 644| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 713| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 729| ·»   »   »   »   "template":·placementSupport.template,
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
| 730| ·»   »   »   »   "x":·placementSupport.position.x,
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
| 735| ·»   »   »   });
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
| 814| »   switch·(inputState)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 817| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 919| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1008| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1022| »   »   »   »   let·action·=·determineAction(ev.x,·ev.y);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'action' is already declared in the upper scope.

binaries/data/mods/public/gui/session/input.js
|1031| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1055| ·»   »   »   »   »   "template":·placementSupport.template,
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
|1056| ·»   »   »   »   »   "x":·placementSupport.position.x,
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
|1057| ·»   »   »   »   »   "z":·placementSupport.position.z,
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
|1060| ·»   »   »   »   });
|    | [NORMAL] ESLintBear (no-mixed-spaces-and-tabs):
|    | Mixed spaces and tabs.

binaries/data/mods/public/gui/session/input.js
|1120| »   »   »   switch·(ev.hotkey)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1550| »   switch·(action)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 241| »   let·actionInfo·=·undefined;
|    | [NORMAL] JSHintBear:
|    | It's not necessary to initialize 'actionInfo' to 'undefined'.

binaries/data/mods/public/gui/session/input.js
| 486| »   »   &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/gui/session/input.js
| 516| »   »   »   »   var·rect·=·updateBandbox(bandbox,·ev,·true);
|    | [NORMAL] JSHintBear:
|    | 'rect' is already defined.

binaries/data/mods/public/gui/session/input.js
| 519| »   »   »   »   var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer));
|    | [NORMAL] JSHintBear:
|    | 'ents' is already defined.

binaries/data/mods/public/gui/session/input.js
| 676| »   »   »   »   »   var·queued·=·Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] JSHintBear:
|    | 'queued' is already defined.

binaries/data/mods/public/gui/session/input.js
| 750| »   »   »   »   var·queued·=·Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] JSHintBear:
|    | 'queued' is already defined.

binaries/data/mods/public/gui/session/input.js
| 863| »   »   »   »   »   »   var·sptr·=·ev.hotkey.split(".");
|    | [NORMAL] JSHintBear:
|    | 'sptr' is already defined.

binaries/data/mods/public/gui/session/input.js
| 879| »   »   »   var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y);
|    | [NORMAL] JSHintBear:
|    | 'ent' is already defined.

binaries/data/mods/public/gui/session/input.js
| 905| »   »   »   }
|    | [NORMAL] JSHintBear:
|    | Expected a 'break' statement before 'default'.

binaries/data/mods/public/gui/session/input.js
| 929| »   »   »   var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y);
|    | [NORMAL] JSHintBear:
|    | 'ent' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2090/display/redirect

Vulcan added a comment.May 9 2020, 8:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/676/display/redirect

Vulcan added a comment.May 9 2020, 8:40 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2091/display/redirect

Imarok updated this revision to Diff 11829.May 10 2020, 3:34 PM

Don't recreate the bug fixed by D2729

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2094/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1568/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/679/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.May 10 2020, 4:22 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.