Page MenuHomeWildfire Games

CivStructure class for civ-specific structures
Needs ReviewPublic

Authored by Nescio on May 13 2020, 10:05 PM.

Details

Reviewers
s0600204
Summary

This patch introduces a "CivStructure" class for those specific structures that should be included in the {civ}.json files and listed in the civilization overview (“History”) page.

There already exist a SpecialBuilding class, however, that one is tied to the template_structure_special,xml file, thus not usable, since not all structures that inherit from *_special are buildable, and since not all civ specific structures inherit from *_special. Therefore an additional class is necessary.

For the Roman siege walls, the class is inserted in the wallset file, which also shows up in the Structure Tree, not in the individual wall segment templates.

According to simulation/components/Identity.js, <Classes> is supposed to be listed below <Tooltip> but above <Icon> and <RequiredTechnology>.

Test Plan

Check for mistakes and omissions.

Event Timeline

Nescio created this revision.May 13 2020, 10:05 PM
Owners added a subscriber: Restricted Owners Package.May 13 2020, 10:05 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2112/display/redirect

Nescio planned changes to this revision.Jul 14 2020, 1:19 PM
Nescio updated this revision to Diff 12933.Jul 27 2020, 10:41 AM
  • rebased and updated

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2786/display/redirect

bb added a subscriber: bb.Sep 25 2020, 5:41 PM

One obstruction for adding this considering the maintainability.

What would be the use case of this class?

What would be the use case of this class?

https://code.wildfiregames.com/D2720#115075

bb added a comment.Sep 25 2020, 11:09 PM

Ahh okay, thanks, needs @s0600204 then...