Page MenuHomeWildfire Games

workshop → arsenal
ClosedPublic

Authored by Nescio on May 21 2020, 7:05 PM.

Details

Summary

The structure for constructing and repairing siege engines in 0 A.D. is called the “workshop”, presumably because Age of Empires had an equivalent “Siege Workshop”. That one game is unable to use proper English doesn't mean this project should follow.
A “workshop” is any place where work is done, and certainly does not imply war machines. The correct English term for storing, repairing, and producing artillery etc. is “arsenal”; see e.g.

This patch thus renames the “workshop” to “arsenal”.
To keep things reviewable, art files are not moved; those can be done in a separate commit.

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.May 21 2020, 7:05 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.May 21 2020, 7:05 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2184/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1657/display/redirect

And as usual, Vulcan can't handle maps with spaces in the file name; see D1042.

Nescio added inline comments.May 21 2020, 7:09 PM
binaries/data/mods/public/simulation/templates/template_structure_military_arsenal.xml
25–30 ↗(On Diff #11955)

Follow order specified in simulation/components/Identity.js.

41–45 ↗(On Diff #11955)

s, p, o are bolt-shooters, l, b stone-throwers.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/769/display/redirect

Nescio updated this revision to Diff 12083.Jun 1 2020, 11:26 AM

rebased

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/883/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2281/display/redirect

Freagarach edited reviewers, added: Freagarach; removed: Restricted Owners Package.Aug 3 2020, 11:32 AM
Freagarach updated this revision to Diff 13087.Aug 5 2020, 7:06 PM

Rebased before committing.

Freagarach accepted this revision.Aug 5 2020, 7:11 PM
  • Change makes sense.
  • Checkrefs passes.
  • units_demo loads fine.
  • Playtesting reveals no errors.
  • PetraAI gets the point.
  • Grepping indicates it's complete.
This revision is now accepted and ready to land.Aug 5 2020, 7:11 PM
Vulcan added a comment.Aug 5 2020, 7:11 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2905/display/redirect

Could you close please, @Nescio? I don't know why it didn't automatically.

This revision was automatically updated to reflect the committed changes.
Nescio added a comment.Aug 5 2020, 9:02 PM

Closed by commit rP23935: Rename workshop to arsenal. (authored by Freagarach). · Explain Why

It's closed?

Yeah, it is closed now indeed, but if you look at the timestamps one can see it took 10 minutes, while most of the time it closes within a few seconds.