Page MenuHomeWildfire Games
Differential D2773

Revert rP23708, rP23710 and rP23711
ClosedPublic
Actions

Authored by wraitii on May 31 2020, 11:45 AM.

Details

Reviewers
None
Commits
rP23714: Revert rP23708, rP23710 and rP23711
Summary

Player-testing has revealed QA issues -> revert, fix , retry later.

I'll let CI run green and merge this.

Test Plan

cc @Krinkle ;)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 31 2020, 11:45 AM
Vulcan added a comment.May 31 2020, 11:48 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2271/display/redirect

Harbormaster failed remote builds in B11872: Diff 12066!May 31 2020, 11:48 AM
wraitii added a comment.May 31 2020, 12:05 PM

I'm going to assume the gcc error is CI weirdness, because it compiles locally and on mac/windows.

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2020, 12:07 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP23714: Revert rP23708, rP23710 and rP23711 (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.
wraitii added a commit: rP23714: Revert rP23708, rP23710 and rP23711.

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
10 lines
49 lines
112 lines
interfaces/
7 lines
tests/
83 lines
source/
simulation2/
components/
5 lines
6 lines
1 line
tests/
1 line

Diff 12067

View Options

ps/trunk/binaries/data/mods/public/simulation/components/GarrisonHolder.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Gate.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/interfaces/UnitAI.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_UnitAI.js

Loading...
View Options

ps/trunk/source/simulation2/components/CCmpObstruction.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/ICmpObstruction.h

Loading...
View Options

ps/trunk/source/simulation2/components/ICmpObstruction.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/tests/test_ObstructionManager.h

Loading...
Wildfire Games · Phabricator