Page MenuHomeWildfire Games

delete maps/scenarios/height*
ClosedPublic

Authored by FeXoR on Jun 1 2020, 10:54 AM.

Details

Reviewers
Nescio
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

As pointed out by @elexis in D1042, the height scenario map files are not actually used, they serve no particular purpose, and their copyright status is unclear, therefore it might be better to simply delete them.

(In contrast, the png files under maps/random/ are meaningful, they serve as a base to generate random maps.)

Test Plan

Verify this patch is correct and complete.

Event Timeline

Nescio created this revision.Jun 1 2020, 10:54 AM
Owners added a subscriber: Restricted Owners Package.Jun 1 2020, 10:54 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/881/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2279/display/redirect

FeXoR added a subscriber: FeXoR.Jun 5 2020, 1:07 PM

While I don't agree they do not serve any purpose since one can import them into Atlas if the copyright status is unclear it's fine for me to delete them.
However, what hints are there that they may be problematic?

Copyright issues should be checked before committing rather than afterwards.
If we assume that every piece of 0 A.D. may not be OK from a copyright point of view we could delete all files ... or assume that the person that committed anything checked for copyright issues.
The latter is more of my taste and I hope we are on the same page with that :p
If anyone is doubting a specific commit was checked this way that person can dig into it and - if problems become apparent - take action (and not because information about copyright can't be traced back!).

So after we have deleted those images will there be further vaguely problematic files in 0 A.D. or will we be done?

FeXoR added a subscriber: Stan.EditedJun 5 2020, 3:00 PM

I'm for @Stan 's suggestion to move them to the art repo.
That way we don't distribute them with our releases but also don't destroy potential material to find out if a copyright infringement took place.
That also is in line with @elexis ' tendency AFAICT ;)

EDIT:
Derived maps:
binaries/data/mods/public/maps/scenarios/campaign_test_map_2_heightmap.xml
binaries/data/mods/public/maps/scenarios/height_map_import_demo_fractal.xml
binaries/data/mods/public/maps/scenarios/height_map_import_demo_greece.xml
binaries/data/mods/public/maps/scenarios/height_map_import_demo_greecesmall.xml

Also some screenshots in:
binaries/data/mods/public/art/textures/ui/session/icons/mappreview

FeXoR removed a subscriber: Stan.Jun 5 2020, 5:20 PM
FeXoR accepted this revision.Jan 15 2021, 2:18 PM
This revision is now accepted and ready to land.Jan 15 2021, 2:18 PM
FeXoR commandeered this revision.Jan 15 2021, 6:13 PM
FeXoR edited reviewers, added: Nescio; removed: FeXoR.

Commandeering revision since it didn't close properly after commit to close it manually.

This revision now requires review to proceed.Jan 15 2021, 6:13 PM
Stan accepted this revision.Jan 15 2021, 6:14 PM
This revision is now accepted and ready to land.Jan 15 2021, 6:14 PM
FeXoR closed this revision.Jan 15 2021, 6:15 PM