Page MenuHomeWildfire Games

[gameplay] allow a few more units on medium and long walls

Authored by Nescio on Jun 3 2020, 1:54 PM.



This patch increases the number of visible garrison slots on medium walls from three to four and on long walls from five to eight.

Most short wall segments have a wall length of 12, medium 24, long 36. Infantry has a footprint radius of 1.5, i.e. a diameter of 3, which means short, medium, long wall can accomodate 4, 8, 12 units, respectively. Because footprints tend to be larger than the actors themselves, things still look good when footprints slightly overlap, e.g. placing them at intervals of 2, which means 6, 12, 18 units on walls. Nonetheless, let's be conservative and stick with intervals of 3. However, wall segments overlap with wall towers, which can be placed quite close to each other, thus the available space is only that part of the wall that's longer than the short segment, hence 0, 4, 8 instead of 4, 8, 12. (1, 5, 9 might also work.)
Roman siege walls are treated slightly differently, since their actors visibly consist of three, six, nine (short, medium, long) repeated elements; sticking with that looks better. Due to turret overlap, the outermost parts are unusable, which leaves four places for the medium and seven for the long siege wall.

The advantages are that it looks better and, if you have the units, makes defending walls somewhat easier, thus improving realism.
See also D2477, D2760, D2769.

Test Plan

Check for mistakes and omissions, agree this is an improvement.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jun 3 2020, 1:54 PM
Owners added a subscriber: Restricted Owners Package.Jun 3 2020, 1:54 PM
Vulcan added a comment.Jun 3 2020, 2:11 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Nescio planned changes to this revision.Jul 20 2020, 1:02 PM
Nescio updated this revision to Diff 12836.Jul 21 2020, 8:07 PM
  • rebased

Successful build - Chance fights ever on the side of the prudent.

Link to build:

borg- accepted this revision.Jul 27 2020, 5:52 PM
borg- added a subscriber: borg-.

I accept Idea, but not sure If code is correct.

This revision is now accepted and ready to land.Jul 27 2020, 5:52 PM
genava55 accepted this revision.Aug 4 2020, 10:01 AM

@genava55, thank you for accepting this patch (and others). However, it's generally helpful to write a little something when accepting, because “accept” can mean different things for different people, e.g.:

  • no objections;
  • approve of the idea, didn't try;
  • tried the parch, did not encounter errors;
  • checked the actual chances, they're fine;
  • verified it's complete and correct;
  • followed the test plan;
  • etc.

"approve of the idea, didn't try"
I think it is a good idea and can be an incentive to use longer wall segments in some cases, and not only shorter segments with more towers.

Thank you for the clarification! (Also elsewhere.)

Nescio removed a reviewer: Restricted Owners Package.Aug 15 2020, 9:04 PM
Freagarach accepted this revision.Sep 3 2020, 7:26 PM

No news is good news.

Template values are correct. (But needs a rebase.)

This revision was automatically updated to reflect the committed changes.