Chandragupta Maurya is the founder of the Mauryan Empire. Maurya is his family name and applies equally to other members of his dynasty (Bindusara, Ashoka, etc.); it is added to distinguish him from the 4th C AD Gupta emperors named after him, but those are outside 0 A.D.'s timeframe.
Chandragupta is his personal name and that is the name his template ought to have.
This patch therefore moves the maur_hero_maurya.xml template to maur_hero_chandragupta.xml, corrects all occurrences, and also renames the related art files.
Details
Details
- Reviewers
Stan - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23834: Rename maurya hero
Check for mistakes and completeness.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2358/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2359/display/redirect
Comment Actions
Patch is okay, checkrefs.pl is happy, and changes make sense.
Not sure why it didn't close, can you close it ?
Comment Actions
Patch is okay, checkrefs.pl is happy, and changes make sense.
Thanks! D2796 is a similar patch, are you willing to review that one too?
Not sure why it didn't close, can you close it ?
But it's already closed?