Page MenuHomeWildfire Games

italiote → italic

Authored by Nescio on Jun 7 2020, 1:38 PM.
Restricted Owners Package
Restricted Owners Package
Restricted Owners Package
Restricted Owners Package


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
rP23949: Rename italiote to italic

0 A.D. currently uses the term "Italiote" [sic]. It's best to use precise language:

  • Italic refers to a branch of Indo-European and the peoples that speak it (cf. Celtic).
  • Italian refers to the modern language, descendant from Latin, the people that speak it, and their country (cf. Romanian).
  • Italiot (from Ἰταλιώτης) refers to Greeks living in Italy (cf. Cypriot).

From the context it's clear what 0 A.D. actually means (Samnites etc.) is Italic.

This patch therefore:

  • Corrects the art file names.
  • Also renames the other embassy icons for consistency (cf. D2551).
  • Corrects the embassy template file name.
  • Adjusts the affected templates, AI, and map file.
  • Deletes the unused Celt, Iberian, Italian classes.
  • Updates the embassy template tooltips (cf. D2578) and cart.json civ file entries.
  • Orders the <Identity> node in the templates as specified in Identity.js.
Test Plan

Check for competeness and correctness. Effectively everything should work as before.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jun 7 2020, 1:38 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Jun 7 2020, 1:38 PM
Vulcan added a comment.Jun 7 2020, 1:40 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build:

Nescio edited the summary of this revision. (Show Details)Jun 7 2020, 1:47 PM
Nescio added inline comments.Jun 7 2020, 1:56 PM
97–114 ↗(On Diff #12199)

Swapped Iberian and Italic embassies to reflect build order, for consistency with the structure tree.

Nescio edited the summary of this revision. (Show Details)Jul 14 2020, 1:20 PM
Nescio updated this revision to Diff 12673.Jul 14 2020, 2:09 PM
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
  • rebased because of rP23802;
  • deleted unused Celt, Iberian, Italian classes;
Owners added a subscriber: Restricted Owners Package.Jul 14 2020, 2:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Stan added a comment.Jul 23 2020, 3:51 PM

On request by angen

I don't have a strong opinion on this. art changes are okay for me. I'm only wondering if it shouldn't be iber_ rome_ and celt_ / gaul_ instead of iberian italiote and celtic, but I'm fine either way. Checkrefs is happy.

5 ↗(On Diff #12673)

I guess we should have a rule for those at some point... Most of the time they are hardcoded because they match animations but there is "Base", "Title Case", "Normal case" not worth a patch though.

Stan accepted this revision.Jul 23 2020, 3:54 PM
This revision is now accepted and ready to land.Jul 23 2020, 3:54 PM
Stan removed a reviewer: Stan.Jul 23 2020, 3:54 PM
This revision now requires review to proceed.Jul 23 2020, 3:54 PM
Nescio added inline comments.Jul 23 2020, 7:04 PM
60 ↗(On Diff #12673)

This line needs to be rebased.
Basically remove unused Celt, Iberian, and Italic classes.

Silier accepted this revision.Aug 1 2020, 7:15 PM

I checked for completeness.

This revision is now accepted and ready to land.Aug 1 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.