Page MenuHomeWildfire Games

[gameplay] Increases the number of embassy.
ClosedPublic

Authored by borg- on Jun 7 2020, 7:56 PM.

Details

Reviewers
ValihrAnt
Feldfeld
PhyZic
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23764: Increase the max # of embassies from 2 to 3.
Summary

Well this is maybe a "irrelevant" change, but it is something that some players ask for, including valihrant.
It seems to make more sense to increase the number of 3 embassies allowed.
Carthaginians have 3 embassies but it is only allowed to build 2, which does not seem to make sense.
Tthere is an @Nescio patch in progress to allow Kushite mercenary colonies to be built in neutral territory, so I think a number greater than 2 looks better.
I'm not sure about number 3, I chose it because it seems to make more sense with cartage.

Test Plan

Without big testes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

borg- created this revision.Jun 7 2020, 7:56 PM
Nescio edited reviewers, added: Restricted Owners Package; removed: Nescio.Jun 7 2020, 9:08 PM

As pointed out in D2534#118987, I don't really care what the limit is.

The idea about having two allowed was probably to force the player to make a choice which one to build. (Refs. rP13801, rP13509 and probably some IRC logs around the time of committing.)

borg- added a comment.EditedJun 8 2020, 12:43 PM

The idea about having two allowed was probably to force the player to make a choice which one to build. (Refs. rP13801, rP13509 and probably some IRC logs around the time of committing.)

Yes, probably a choice but If i have two embassys and my enemy changes you strategy and i need some diferent embassy, so i need delete one embassy for can build another. I think your need a chance to build all embassy, cartage is very dependent of mercenaries.

@ValihrAnt @Feldfeld some opnion about?

PhyZic added a subscriber: PhyZic.Jun 8 2020, 5:55 PM

Good idea.

Nescio added a comment.Jun 8 2020, 8:23 PM

Good idea.

If you approve of a patch, you can click “Add Action...” → “Accept Revision”.

PhyZic accepted this revision.Jun 8 2020, 9:43 PM
This revision is now accepted and ready to land.Jun 8 2020, 9:43 PM
borg- added a comment.Jun 9 2020, 2:14 PM

@ValihrAnt seems to agree.

"Having higher capacity is something I've wanted for a long time, though I think this might be out of scope for this patch." Commented on D2534.

ValihrAnt accepted this revision as: ValihrAnt.Jun 12 2020, 1:58 PM

The limit of 2 embassies is very annoying as you only have 3 units in the barrack and you're reliant on the embassies for everything else. A limit of 2 is terrible for being able to get a decent amount of any unit out, especially if you go for Expertise in War which slows down train time.

wraitii accepted this revision.Jun 12 2020, 2:00 PM

I don't have a very strong opiionn, I agree it's nice to be able to build all 3 embassy types. It doesn't seem like a huge buff either.

if you both agree I think this is fine to commit.

This revision was automatically updated to reflect the committed changes.