Page MenuHomeWildfire Games

Fix error following rP23747
ClosedPublic

Authored by wraitii on Jun 7 2020, 9:55 PM.

Details

Reviewers
None
Commits
rP23748: Fix error in rP23747.
Summary

Fix errors when HWDetect tries to set a config value.


I failed to notice that hwdetect wasn't actually taking any of the branches that call Engine.ConfigDB_CreateValue, and thus didn't actually test them, and thus didn't noticed that they failed.

Test Plan

@Nescio Can you confirm that this fixes your issue?

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jun 7 2020, 9:55 PM
Vulcan added a comment.Jun 7 2020, 9:56 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2365/display/redirect

Nescio added a comment.Jun 7 2020, 9:59 PM

@Nescio Can you confirm that this fixes your issue?

Yeah, this appears to solve the problem, after a quick rebuilt the error is no longer there, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jun 7 2020, 10:12 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP23748: Fix error in rP23747. (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.
Stan added a subscriber: Stan.Jun 7 2020, 10:12 PM
Stan added inline comments.
binaries/data/mods/mod/hwdetect/hwdetect.js
362 ↗(On Diff #12208)

Config don't support booleans?

364 ↗(On Diff #12208)

Leftover/test?

wraitii added inline comments.Jun 7 2020, 10:15 PM
binaries/data/mods/mod/hwdetect/hwdetect.js
362 ↗(On Diff #12208)

They don't.

364 ↗(On Diff #12208)

-____________________-