Page MenuHomeWildfire Games

group defensive structures together
ClosedPublic

Authored by Nescio on Jun 10 2020, 11:46 AM.

Details

Summary

This patch groups defensive structures together in the build list. Since they tend to be built later than civic (e.g. house), economic (e.g. farmstead), and military (e.g. barracks) structures, they're listed at the end, just before the Wonder. Wallsets are listed after towers, which are more common.
This is how it looks in game:



It does not affect balance and is basically a follow-up to D2580/rP23548.

Test Plan

Check for mistakes and omissions, agree with the proposed order.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jun 10 2020, 11:46 AM
Owners added a subscriber: Restricted Owners Package.Jun 10 2020, 11:46 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2390/display/redirect

Freagarach added a comment.EditedJun 10 2020, 12:27 PM

(Kind of refs. #5613.)

bb requested changes to this revision.Aug 26 2020, 3:06 PM
bb added a subscriber: bb.

females and slaves need the same treatment.

binaries/data/mods/public/simulation/templates/template_unit_infantry.xml
40 ↗(On Diff #12241)

Somehow it makes sense to me to move the workshop in between the barracks and the blacksmith

This revision now requires changes to proceed.Aug 26 2020, 3:06 PM
Nescio updated this revision to Diff 13299.Aug 26 2020, 5:18 PM
  • rebased and updated
  • barracks, arsenal, forge, temple, per @bb
bb accepted this revision.Aug 26 2020, 5:30 PM
bb removed a reviewer: Restricted Owners Package.
This revision is now accepted and ready to land.Aug 26 2020, 5:30 PM
bb added a comment.Aug 26 2020, 5:33 PM

Pre rP23548, the ordering was by phase, common agreement there broke that and hence better group buildings by function then.

This revision was automatically updated to reflect the committed changes.